fluidsynth: Migrate to by-name.

fluidsynth: Add conditionals to provide default values on darwin

Simplify package.nix

Format to RFC style.

Apply suggestions from code review

Co-authored-by: Pol Dellaiera <[email protected]>

 Fix nix file

fluidsynth: update meta attributes to use lib

fluidsynth: simplify derivation definition

fluidsynth: refactor derivation to use final attributes for versioning

fluidsynth: Update meta attribute structure

Update pkgs/by-name/fl/fluidsynth/package.nix

Co-authored-by: Pol Dellaiera <[email protected]>

Add license.

Co-authored-by: Pol Dellaiera <[email protected]>

Author: guylamar2006

pkgs/applications/audio/fluidsynth/default.nix

@@ -0,0 +1,72 @@
+{
+  stdenv,
+  darwin,
+  lib,
+  fetchFromGitHub,
+  buildPackages,
+  pkg-config,
+  cmake,
+  alsa-lib,
+  glib,
+  libjack2,
+  libsndfile,
+  libpulseaudio,
+}:
+
+stdenv.mkDerivation (finalAttrs: {
+  pname = "fluidsynth";
+  version = "2.4.3";
+
+  src = fetchFromGitHub {
+    owner = "FluidSynth";
+    repo = "fluidsynth";
+    tag = "v${finalAttrs.version}";
+    hash = "sha256-LaJcWrHgt/RzlDQmpzOjF/9ugD5d+8XWRt7pU3SM5Rk=";
+  };
+
+  outputs = [
+    "out"
+    "dev"
+    "man"
+  ];
+
+  nativeBuildInputs = [
+    buildPackages.stdenv.cc
+    pkg-config
+    cmake
+  ];
+
+  buildInputs =
+    [
+      glib
+      libsndfile
+      libjack2
+    ]
+    ++ lib.optionals stdenv.hostPlatform.isLinux [
+      alsa-lib
+      libpulseaudio
+    ]
+    ++ lib.optionals stdenv.hostPlatform.isDarwin (
+      with darwin.apple_sdk.frameworks;
+      [
+        AppKit
+        AudioUnit
+        CoreAudio
+        CoreMIDI
+        CoreServices
+      ]
+    );
+
+  cmakeFlags = [
+    "-Denable-framework=off"
+  ];
+
+  meta = {
+    description = "Real-time software synthesizer based on the SoundFont 2 specifications";
+    homepage = "https://www.fluidsynth.org";
+    license = lib.licenses.lgpl21Plus;
+    maintainers = with lib.maintainers; [ lovek323 ];
+    platforms = lib.platforms.unix;
+    mainProgram = "fluidsynth";
+  };
+})

pkgs/by-name/fl/fluidsynth/package.nix

@@ -12908,10 +12908,6 @@ with pkgs;
     hamlib = hamlib_4;
   };
 
-  fluidsynth = callPackage ../applications/audio/fluidsynth {
-    inherit (darwin.apple_sdk.frameworks) AppKit AudioUnit CoreAudio CoreMIDI CoreServices;
-  };
-
   fmit = libsForQt5.callPackage ../applications/audio/fmit { };
 
   fnc = darwin.apple_sdk_11_0.callPackage ../applications/version-management/fnc { };