Skip to content

Commit f6d31ad

Browse files
authored
python312Packages.jax: clean python-packages.nix call (NixOS#375269)
2 parents b3af27b + a0c6398 commit f6d31ad

File tree

2 files changed

+25
-32
lines changed

2 files changed

+25
-32
lines changed

pkgs/development/python-modules/jaxlib/default.nix

Lines changed: 24 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
cython,
1616
fetchFromGitHub,
1717
git,
18-
IOKit,
18+
darwin,
1919
jsoncpp,
2020
nsync,
2121
openssl,
@@ -242,25 +242,22 @@ let
242242
which
243243
] ++ lib.optionals effectiveStdenv.hostPlatform.isDarwin [ cctools ];
244244

245-
buildInputs =
246-
[
247-
curl
248-
double-conversion
249-
giflib
250-
jsoncpp
251-
libjpeg_turbo
252-
numpy
253-
openssl
254-
pkgs.flatbuffers
255-
pkgs.protobuf
256-
pybind11
257-
scipy
258-
six
259-
snappy
260-
zlib
261-
]
262-
++ lib.optionals effectiveStdenv.hostPlatform.isDarwin [ IOKit ]
263-
++ lib.optionals (!effectiveStdenv.hostPlatform.isDarwin) [ nsync ];
245+
buildInputs = [
246+
curl
247+
double-conversion
248+
giflib
249+
jsoncpp
250+
libjpeg_turbo
251+
numpy
252+
openssl
253+
pkgs.flatbuffers
254+
pkgs.protobuf
255+
pybind11
256+
scipy
257+
six
258+
snappy
259+
zlib
260+
] ++ lib.optionals (!effectiveStdenv.hostPlatform.isDarwin) [ nsync ];
264261

265262
# We don't want to be quite so picky regarding bazel version
266263
postPatch = ''
@@ -393,12 +390,12 @@ let
393390
}
394391
).${effectiveStdenv.system} or (throw "jaxlib: unsupported system: ${effectiveStdenv.system}");
395392

396-
# Non-reproducible fetch https://github.com/NixOS/nixpkgs/issues/321920#issuecomment-2184940546
397-
preInstall = ''
398-
cat << \EOF > "$bazelOut/external/go_sdk/versions.json"
399-
[]
400-
EOF
401-
'';
393+
# Non-reproducible fetch https://github.com/NixOS/nixpkgs/issues/321920#issuecomment-2184940546
394+
preInstall = ''
395+
cat << \EOF > "$bazelOut/external/go_sdk/versions.json"
396+
[]
397+
EOF
398+
'';
402399
};
403400

404401
buildAttrs = {
@@ -415,7 +412,7 @@ let
415412
# are not available yet. Framework search paths aren't added by bintools
416413
# hook. See https://github.com/NixOS/nixpkgs/pull/41914.
417414
preBuild = lib.optionalString effectiveStdenv.hostPlatform.isDarwin ''
418-
export NIX_LDFLAGS+=" -F${IOKit}/Library/Frameworks"
415+
export NIX_LDFLAGS+=" -F${darwin.apple_sdk.frameworks.IOKit}/Library/Frameworks"
419416
substituteInPlace ../output/external/rules_cc/cc/private/toolchain/osx_cc_wrapper.sh.tpl \
420417
--replace "/usr/bin/install_name_tool" "${cctools}/bin/install_name_tool"
421418
substituteInPlace ../output/external/rules_cc/cc/private/toolchain/unix_cc_configure.bzl \

pkgs/top-level/python-packages.nix

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6602,11 +6602,7 @@ self: super: with self; {
66026602

66036603
jaxlib-bin = callPackage ../development/python-modules/jaxlib/bin.nix { };
66046604

6605-
jaxlib-build = callPackage ../development/python-modules/jaxlib rec {
6606-
# Some platforms don't have `cudaSupport` defined, hence the need for 'or false'.
6607-
inherit (pkgs.config) cudaSupport;
6608-
IOKit = pkgs.darwin.apple_sdk_11_0.IOKit;
6609-
};
6605+
jaxlib-build = callPackage ../development/python-modules/jaxlib { };
66106606

66116607
jaxlib = jaxlib-bin;
66126608

0 commit comments

Comments
 (0)