Harden Win GUI startup logging and trace encoder ctor log

Author: secup

include/ultra/logging.hpp

@@ -75,12 +75,12 @@ inline void log(LogLevel level, const char* category, const char* format, ...) {
     FILE* out = g_log_file;
     if (!out) {
 #ifdef _WIN32
-        // GUI-subsystem processes can have an invalid stderr stream on some Win10 setups.
-        if (!stderr || _fileno(stderr) < 0) {
-            return;
-        }
-#endif
+        // GUI-subsystem processes can have an invalid stderr stream on Win10.
+        // Avoid using stderr entirely on Windows unless an explicit log file is set.
+        return;
+#else
         out = stderr;
+#endif
     }
 
     // Get elapsed time in milliseconds

src/gui/main_gui.cpp

@@ -86,12 +86,17 @@ void initStartupLog() {
     }
 
     if (g_startup_log_file) {
+        // Ensure early LOG_* calls during App/Modem construction have a valid sink.
+        ultra::setLogFile(g_startup_log_file);
         writeStartupLog("ProjectUltra GUI startup log initialized");
     }
 }
 
 void closeStartupLog() {
     if (g_startup_log_file) {
+        if (ultra::g_log_file == g_startup_log_file) {
+            ultra::setLogFile(nullptr);
+        }
         writeStartupLog("ProjectUltra GUI startup log closing");
         std::fclose(g_startup_log_file);
         g_startup_log_file = nullptr;

src/gui/modem/streaming_encoder.cpp

@@ -56,8 +56,10 @@ StreamingEncoder::StreamingEncoder() {
     updateInterleaver();
     startupTrace("StreamingEncoder", "update-interleaver-exit");
 
+    startupTrace("StreamingEncoder", "ctor-log-enter");
     LOG_MODEM(INFO, "StreamingEncoder: Initialized (mode=%s, carriers=%d)",
               protocol::waveformModeToString(mode_), ofdm_config_.num_carriers);
+    startupTrace("StreamingEncoder", "ctor-log-exit");
     startupTrace("StreamingEncoder", "ctor-exit");
 }