Skip to content

Commit 708ff39

Browse files
feat(trustroots):refactor-common-components
1 parent 84aa096 commit 708ff39

File tree

4 files changed

+23
-15
lines changed

4 files changed

+23
-15
lines changed

client/src/app/pages/Certificates/CertificatesPage.tsx

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import {
1111
Pagination,
1212
PaginationVariant,
1313
Popper,
14-
SearchInput,
1514
Toolbar,
1615
ToolbarContent,
1716
ToolbarFilter,
@@ -26,6 +25,7 @@ import { useCallback, useEffect, useRef, useState } from "react";
2625
import type { ICertificateProps } from "./Certificates.data";
2726
import ShieldIcon from "@patternfly/react-icons/dist/esm/icons/shield-alt-icon";
2827
import { capitalizeFirstLetter, formatDate, getCertificateStatusColor } from "@app/utils/utils";
28+
import { PublishedOnInput, SearchInputField } from "@app/shared-components/SearchInputField";
2929

3030
export interface ICertificatesPageProps {
3131
certificates: ICertificateProps[];
@@ -232,18 +232,7 @@ const CertificatesPage = ({ certificates, columns }: ICertificatesPageProps) =>
232232
</div>
233233
);
234234

235-
// Set up identifier search input
236-
const searchInput = (
237-
<SearchInput
238-
placeholder="Filter by text"
239-
value={searchValue}
240-
onChange={(_event, value) => onSearchChange(value)}
241-
onClear={() => onSearchChange("")}
242-
/>
243-
);
244235

245-
// Set up date filter
246-
const publishedOnInput = <>Date range input here</>;
247236

248237
const toggleGroupItems = (
249238
<ToolbarGroup variant="filter-group">
@@ -255,10 +244,10 @@ const CertificatesPage = ({ certificates, columns }: ICertificatesPageProps) =>
255244
categoryName="Subject"
256245
showToolbarItem={activeAttributeMenu === "Filter text"}
257246
>
258-
{searchInput}
247+
<SearchInputField searchValue={searchValue} onSearchChange={onSearchChange} />
259248
</ToolbarFilter>
260249
<ToolbarFilter categoryName={"Valid To"} showToolbarItem={activeAttributeMenu === "Valid To"}>
261-
{publishedOnInput}
250+
<PublishedOnInput />
262251
</ToolbarFilter>
263252
<ToolbarItem variant="pagination">{renderPagination("top", true)}</ToolbarItem>
264253
</ToolbarGroup>

client/src/app/pages/TrustRoots/components/TrustRootRow.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {
1414
type MenuToggleElement,
1515
} from "@patternfly/react-core";
1616
import * as React from "react";
17-
import StatusIcon from "./StatusIcon";
17+
import StatusIcon from "../../../shared-components/StatusIcon";
1818
import CodeBranchIcon from "@patternfly/react-icons/dist/esm/icons/code-branch-icon";
1919
import CubeIcon from "@patternfly/react-icons/dist/esm/icons/cube-icon";
2020
import { CalendarAltIcon, FileAltIcon, EllipsisVIcon } from "@patternfly/react-icons";
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
import { SearchInput } from "@patternfly/react-core";
2+
3+
interface SearchInputFieldProps {
4+
searchValue: string;
5+
onSearchChange: (value: string) => void;
6+
}
7+
8+
// Set up identifier search input
9+
export const SearchInputField: React.FC<SearchInputFieldProps> = ({ searchValue, onSearchChange }) =>
10+
<SearchInput
11+
placeholder="Filter by text"
12+
value={searchValue}
13+
onChange={(_event, value) => onSearchChange(value)}
14+
onClear={() => onSearchChange("")}
15+
/>
16+
17+
18+
// Set up date filter
19+
export const PublishedOnInput = () => <>Date range input here</>;

0 commit comments

Comments
 (0)