Skip to content

CF PRs from forks preview deployments #280

@scode2277

Description

@scode2277

Type of request

  • Strategy (planning, high-level discussions, roadmap)
  • Tech (infrastructure, tooling, tech stack)
  • Other

Why are you raising this issue?

The problem is:
we need preview deployments in the PRs (from forks/external contributors). We are migrating to Cloudflare Pages and we noted that it does not support these kind of deployments (not yet, but they are working on implementing it -> https://developers.cloudflare.com/pages/platform/known-issues/#builds-and-deployment ⬇️

Commits/PRs from forked repositories will not create a preview. Support for this will come in the future.

There is this workaround github action that would solve this preview deployments problem. This is how it works:

  • in the .github folder, we would need to add a workflow that builds the code and call the action passing the build outputs and the API Token to make it deploy on CF

The "problem" (quoted because it's not an actual problem, more a collateral) is:

  • to enable the action we would need to disable the CF built-in continuous and automatic deployments for the whole repo - meaning that we have to disconnect the repo from the CF account
  • that means not having anymore the continuous CF deployments at all, not even for the main and develop branch (as well as all the other branches of the repo)
  • so, that naturally means that we would need to have yet another workflow (actually 2, one for building and the second for deploying) to make the branches deployments

All the above considerations led us to the decision of not implementing this github action for the moment, as for our use case it's not worth it.
What we will implement, as we anyhow want to migrate the .org and .dev sites to CF Pages (for many many reason, e.g. it solves the redirects problem we have with vercel), is that we will keep Vercel's deployments just for the PRs from fork preview deployments while we wait or for CF to implement these deployments or for a better solution to this

Why do you think it is important?

No response

Can you justify your argument or provide additional resources?

Contribution intent

  • I can work on implementing this
  • I'm raising this for discussion/someone else to handle

Metadata

Metadata

Assignees

No one assigned

    Labels

    local setupImprovements or additions to the local setup

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions