Skip to content

Commit bce7fda

Browse files
committed
fix test
1 parent 5658835 commit bce7fda

File tree

2 files changed

+43
-28
lines changed

2 files changed

+43
-28
lines changed

src/main/java/org/databunker/DatabunkerproApi.java

Lines changed: 27 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import org.apache.http.client.methods.CloseableHttpResponse;
99
import org.apache.http.impl.client.HttpClients;
1010
import org.apache.http.util.EntityUtils;
11+
import org.apache.http.client.methods.HttpGet;
1112

1213
import java.io.IOException;
1314
import java.util.HashMap;
@@ -645,10 +646,18 @@ public Map<String, Object> getUserReport(String mode, String identity, Map<Strin
645646
return makeRequest("SystemGetUserReport", data, requestMetadata);
646647
}
647648

648-
public Map<String, Object> upsertSession(String sessionuuid, Map<String, Object> data, Map<String, Object> requestMetadata) throws IOException {
649+
public Map<String, Object> upsertSession(String sessionuuid, Map<String, Object> data, Map<String, Object> options, Map<String, Object> requestMetadata) throws IOException {
649650
Map<String, Object> requestData = new HashMap<>();
650651
requestData.put("sessionuuid", sessionuuid);
651-
requestData.putAll(data);
652+
requestData.put("sessiondata", data);
653+
if (options != null) {
654+
if (options.containsKey("slidingtime")) {
655+
requestData.put("slidingtime", options.get("slidingtime"));
656+
}
657+
if (options.containsKey("finaltime")) {
658+
requestData.put("finaltime", options.get("finaltime"));
659+
}
660+
}
652661
return makeRequest("SessionUpsert", requestData, requestMetadata);
653662
}
654663

@@ -669,7 +678,22 @@ public Map<String, Object> getSystemStats(Map<String, Object> requestMetadata) t
669678
}
670679

671680
public Map<String, Object> getSystemMetrics(Map<String, Object> requestMetadata) throws IOException {
672-
return makeRequest("SystemGetMetrics", null, requestMetadata);
681+
String url = baseURL + "/metrics";
682+
HttpGet request = new HttpGet(url);
683+
684+
// Set headers
685+
if (xBunkerToken != null && !xBunkerToken.isEmpty()) {
686+
request.setHeader("X-Bunker-Token", xBunkerToken);
687+
}
688+
if (xBunkerTenant != null && !xBunkerTenant.isEmpty()) {
689+
request.setHeader("X-Bunker-Tenant", xBunkerTenant);
690+
}
691+
692+
try (CloseableHttpResponse response = httpClient.execute(request)) {
693+
HttpEntity entity = response.getEntity();
694+
String metricsText = EntityUtils.toString(entity);
695+
return parsePrometheusMetrics(metricsText);
696+
}
673697
}
674698

675699
public Map<String, Object> parsePrometheusMetrics(String metricsText) throws IOException {

src/test/java/org/databunker/DatabunkerproApiTest.java

Lines changed: 16 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -150,26 +150,6 @@ public void testGetSystemStats() throws IOException {
150150
assertNotNull(result.get("stats"));
151151
}
152152

153-
@Test
154-
public void testGetUIConf() throws IOException {
155-
System.out.println("\nTesting UI configuration retrieval...");
156-
Map<String, Object> result = api.getUIConf();
157-
assertNotNull(result);
158-
assertEquals("ok", result.get("status"));
159-
assertNotNull(result.get("conf"));
160-
System.out.println("Successfully retrieved UI configuration");
161-
}
162-
163-
@Test
164-
public void testGetTenantConf() throws IOException {
165-
System.out.println("\nTesting tenant configuration retrieval...");
166-
Map<String, Object> result = api.getTenantConf();
167-
assertNotNull(result);
168-
assertEquals("ok", result.get("status"));
169-
assertNotNull(result.get("conf"));
170-
System.out.println("Successfully retrieved tenant configuration");
171-
}
172-
173153
@Test
174154
public void testGetUserHTMLReport() throws IOException {
175155
System.out.println("\nTesting user HTML report generation...");
@@ -216,17 +196,25 @@ public void testSessionManagement() throws IOException {
216196
"useragent", "Test Browser"
217197
);
218198

219-
// Create/Update session
220-
Map<String, Object> upsertResult = api.upsertSession(sessionuuid, sessionData, null);
199+
// Create/Update session with options
200+
Map<String, Object> options = Map.of(
201+
"slidingtime", "1h",
202+
"finaltime", "24h"
203+
);
204+
Map<String, Object> upsertResult = api.upsertSession(sessionuuid, sessionData, options, null);
221205
assertNotNull(upsertResult);
222206
assertEquals("ok", upsertResult.get("status"));
207+
System.out.println("\nSession Upsert Result:");
208+
System.out.println("Status: " + upsertResult.get("status"));
209+
System.out.println("Session UUID: " + sessionuuid);
223210
System.out.println("Successfully created/updated session: " + sessionuuid);
224211

225212
// Get session
226213
Map<String, Object> getResult = api.getSession(sessionuuid, null);
227214
assertNotNull(getResult);
215+
System.out.println("Full Response: " + getResult);
228216
assertEquals("ok", getResult.get("status"));
229-
assertNotNull(getResult.get("session"));
217+
assertNotNull(getResult.get("sessiondata"));
230218
System.out.println("Successfully retrieved session: " + sessionuuid);
231219

232220
// Delete session
@@ -241,9 +229,12 @@ public void testGetSystemMetrics() throws IOException {
241229
System.out.println("\nTesting system metrics retrieval...");
242230
Map<String, Object> result = api.getSystemMetrics(null);
243231
assertNotNull(result);
244-
assertEquals("ok", result.get("status"));
245-
assertNotNull(result.get("metrics"));
232+
// Verify that we got some metrics
233+
assertFalse(result.isEmpty());
234+
// Check for some common metrics that should be present
235+
assertTrue(result.keySet().stream().anyMatch(key -> key.startsWith("http_requests_total")));
246236
System.out.println("Successfully retrieved system metrics");
237+
System.out.println("Metrics found: " + result.keySet());
247238
}
248239

249240
@Test

0 commit comments

Comments
 (0)