chore(vault): add smtp config to flags for coherence

Author: burdiyan

vault/AGENTS.md

@@ -116,3 +116,4 @@ For more information, read the Bun API docs in `node_modules/bun-types/docs/**.m
 - Make sure to remove rambling "stream of consciousness" (a.k.a. thinking out loud) comments in the final code.
 - Prefer broader integration-style tests. Avoid excessive mocking.
 - Consult files in `docs/` to see if there's anything relevant for your current job.
+- Flags are the primary way to configure this application, and they are the source of truth, with the benefit of being self-documenting. Environment variables are layered on top of flags. See @src/config.ts for how configuration is managed.

vault/src/config.ts

@@ -19,40 +19,71 @@ export type Config = {
 	smtp: email.SmtpConfig | null
 }
 
-export const flags = {
+/** Creates flag definitions with default values parsed from the current env. */
+export const flags = (env: NodeJS.ProcessEnv = process.env) => ({
 	"server-hostname": {
 		type: String,
-		default: process.env.SEED_VAULT_HTTP_HOSTNAME || "0.0.0.0",
+		default: env.SEED_VAULT_HTTP_HOSTNAME || "0.0.0.0",
 		description: "The hostname to bind the HTTP server to",
 	},
 	"server-port": {
 		type: Number,
-		default: Number(process.env.SEED_VAULT_HTTP_PORT) || 3000,
+		default: Number(env.SEED_VAULT_HTTP_PORT) || 3000,
 		description: "The port to bind the HTTP server to",
 	},
+
 	"rp-id": {
 		type: String,
-		default: process.env.SEED_VAULT_RP_ID || "",
+		default: env.SEED_VAULT_RP_ID || "",
 		description: "The relying party ID",
 	},
 	"rp-name": {
 		type: String,
-		default: process.env.SEED_VAULT_RP_NAME || "Seed Hypermedia Identity Vault",
+		default: env.SEED_VAULT_RP_NAME || "Seed Hypermedia Identity Vault",
 		description: "The relying party name",
 	},
 	"rp-origin": {
 		type: String,
-		default: process.env.SEED_VAULT_RP_ORIGIN || "",
+		default: env.SEED_VAULT_RP_ORIGIN || "",
 		description: "The relying party origin",
 	},
+
 	"db-path": {
 		type: String,
-		default: process.env.SEED_VAULT_DB_PATH || "vault.sqlite",
+		default: env.SEED_VAULT_DB_PATH || "vault.sqlite",
 		description: "Path to the database file",
 	},
-}
 
-type ParsedFlags = cleye.TypeFlag<typeof flags>["flags"]
+	"smtp-host": {
+		type: String,
+		default: env.SEED_VAULT_SMTP_HOST || "",
+		description: "The SMTP host to use for sending emails",
+	},
+	"smtp-port": {
+		type: Number,
+		default: Number(env.SEED_VAULT_SMTP_PORT) || 587,
+		description: "The SMTP port to use for sending emails",
+	},
+	"smtp-user": {
+		type: String,
+		default: env.SEED_VAULT_SMTP_USER || "",
+		description: "The SMTP username to use for sending emails",
+	},
+	"smtp-password": {
+		type: String,
+		default: env.SEED_VAULT_SMTP_PASSWORD || "",
+		description: "The SMTP password to use for sending emails",
+	},
+	"smtp-sender": {
+		type: String,
+		default: env.SEED_VAULT_SMTP_SENDER || "",
+		description: "The email address to use as the sender",
+	},
+})
+
+type FlagsDef = ReturnType<typeof flags>
+
+type ParsedFlags = cleye.TypeFlag<FlagsDef>["flags"]
 
 export function create(pflags: ParsedFlags): Config {
 	const http: Server = {
@@ -74,21 +105,22 @@ export function create(pflags: ParsedFlags): Config {
 		throw new Error("Relying party origin configuration is required")
 	}
 
-	const smtpHost = process.env.SEED_VAULT_SMTP_HOST
-	const smtp: email.SmtpConfig | null = smtpHost
+	const dbPath = pflags["db-path"]
+
+	const smtp = pflags["smtp-host"]
 		? {
-				host: smtpHost,
-				port: Number(process.env.SEED_VAULT_SMTP_PORT) || 587,
-				user: process.env.SEED_VAULT_SMTP_USER || "",
-				password: process.env.SEED_VAULT_SMTP_PASSWORD || "",
-				sender: process.env.SEED_VAULT_SMTP_SENDER || "",
+				host: pflags["smtp-host"],
+				port: pflags["smtp-port"],
+				user: pflags["smtp-user"],
+				password: pflags["smtp-password"],
+				sender: pflags["smtp-sender"],
 			}
 		: null
 
 	return {
 		http,
 		relyingParty,
-		dbPath: pflags["db-path"],
+		dbPath,
 		smtp,
 	}
 }

vault/src/main.ts

@@ -30,7 +30,7 @@ function collectStaticAssets(dir: string, urlPrefix: string): Map<string, Return
 async function main() {
 	const argv = cli({
 		name: "seed-vault",
-		flags: config.flags,
+		flags: config.flags(),
 		strictFlags: true,
 	})