chore: tests passing

Author: ericvicenti

frontend/apps/web/app/ssr-document.integration.test.ts

@@ -99,6 +99,7 @@ vi.mock('@shm/shared/models/search', async (importOriginal) => {
 vi.mock('@/auth', () => ({
   useLocalKeyPair: () => null,
   useCreateAccount: () => ({content: null, createAccount: () => {}}),
+  AccountFooterActions: () => null,
 }))
 
 // Mock navigation hooks used by WebResourcePage

frontend/packages/shared/src/__tests__/document-utils.test.ts

@@ -16,6 +16,7 @@ describe('prepareHMDocument', () => {
         account: 'test-account',
         authors: ['author1'],
         genesis: 'genesis-id',
+        visibility: 'PUBLIC',
         createTime: '2024-01-01T00:00:00Z',
         updateTime: '2024-01-01T00:00:00Z',
       }),
@@ -126,6 +127,7 @@ describe('prepareHMComment', () => {
         author: 'test-author',
         targetAccount: 'target-account',
         targetVersion: 'target-version',
+        visibility: 'PUBLIC',
         createTime: '2024-01-01T00:00:00Z',
         updateTime: '2024-01-01T00:00:00Z',
       }),

frontend/packages/shared/src/utils/__tests__/entity-id-url.test.ts

@@ -1,6 +1,7 @@
 import {describe, expect, test} from 'vitest'
 import {
   createCommentUrl,
+  createOSProtocolUrl,
   createSiteUrl,
   createWebHMUrl,
   hmId,
@@ -155,6 +156,20 @@ describe('hmId', () => {
   })
 })
 
+describe('createOSProtocolUrl', () => {
+  test('creates hm:// URL for desktop protocol', () => {
+    expect(
+      createOSProtocolUrl(
+        hmId('abc123', {
+          path: ['foo'],
+          version: 'v1',
+          blockRef: 'blockA',
+        }),
+      ),
+    ).toBe('hm://abc123/foo?v=v1#blockA')
+  })
+})
+
 describe('unpackHmId - blockRef and version precedence', () => {
   test('blockRef with ?l param - blockRef takes precedence, latest=false', () => {
     // When blockRef is present, ?l should be ignored because

frontend/packages/shared/src/utils/entity-id-url.ts

@@ -1,5 +1,14 @@
-import {BlockRange, HMComment, ParsedFragment, UnpackedHypermediaId} from '..'
-import {DEFAULT_GATEWAY_URL, HYPERMEDIA_SCHEME} from '../constants'
+import type {
+  BlockRange,
+  HMComment,
+  ParsedFragment,
+  UnpackedHypermediaId,
+} from '../hm-types'
+import {
+  DEFAULT_GATEWAY_URL,
+  HYPERMEDIA_SCHEME,
+  OS_PROTOCOL_SCHEME,
+} from '../constants'
 import {NavRoute} from '../routes'
 import {entityQueryPathToHmIdPath} from './path-api'
 import {StateStream} from './stream'
@@ -242,8 +251,6 @@ export function createOSProtocolUrl({
   blockRef,
   blockRange,
 }: UnpackedHypermediaId) {
-  // Import at runtime to avoid circular dependency
-  const {OS_PROTOCOL_SCHEME} = require('../constants')
   let res = `${OS_PROTOCOL_SCHEME}://${uid}`
 
   if (path && path.length) {