Skip to content

Commit 694508f

Browse files
refactor: ♻️ apply suggestions from code review
Co-authored-by: Luke W. Johnston <[email protected]>
1 parent a406550 commit 694508f

File tree

8 files changed

+7
-26
lines changed

8 files changed

+7
-26
lines changed

copier.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ _subdirectory: template
33
# Post-copy commands:
44
_tasks:
55
# Add dev dependencies
6-
- command: "git init -b main && uv add --dev pre-commit ruff typos pytest bandit commitizen genbadge jupyter pytest-cov quartodoc types-tabulate mypy vulture"
6+
- command: "git init -b main; uv add --dev pre-commit ruff typos pytest bandit commitizen genbadge jupyter pytest-cov quartodoc types-tabulate mypy vulture"
77
when: "{{ _copier_operation == 'copy' }}"
88
# If Seedcase project, add seedcase-theme extension
99
- command: "just update-quarto-theme"
@@ -109,7 +109,7 @@ review_team:
109109

110110
github_board_number:
111111
type: str
112-
help: "What is the number of the GitHub project board to add issues and PRs to?"
112+
help: "What is the GitHub project board number to add issues and PRs to?"
113113
validator: |
114114
{% if github_board_number and not github_board_number.isdigit() %}
115115
The board number must be an integer.

justfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ test is_seedcase_project:
6060
--defaults \
6161
--trust \
6262
--data github_user="first-last" \
63-
--data package_name=$test_name \
6463
--data is_seedcase_project={{ is_seedcase_project }} \
6564
--data author_given_name="First" \
6665
--data author_family_name="Last" \
@@ -96,7 +95,6 @@ test is_seedcase_project:
9695
--trust \
9796
--overwrite \
9897
--data github_user="first-last" \
99-
--data package_name=$test_name \
10098
--data is_seedcase_project={{ is_seedcase_project }} \
10199
--data author_given_name="First" \
102100
--data author_family_name="Last" \

template/.github/CODEOWNERS.jinja

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,3 @@
11
# All members on Developers team get added to review PRs
22
* {{ review_team }}
33

4-
# Ignore these so we don't get added to sync PRs
5-
/.github/
6-
/.vscode/
7-
/.devcontainer/
8-
justfile
9-
.editorconfig
10-
.gitignore
11-
ruff.toml
12-
pyproject.toml
13-
uv.lock

template/.github/dependabot.yml.jinja

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
version: 2
22
updates:
3-
- package-ecosystem: pip
3+
- package-ecosystem: uv
44
directory: /
55
schedule:
66
interval: monthly

template/_quarto.yml.jinja

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ project:
77
- "index.qmd"
88

99
website:
10-
title: "{{ 'Seedcase ' ~ (seedcase_short_name | title) if is_seedcase_project else package_name }}"
10+
# TODO: Fill in the title of the website.
11+
title: ""
1112
site-url: "{{ homepage }}"
1213
repo-url: "https://github.com/{{ package_github_repo }}"
1314
page-navigation: true

template/index.qmd.jinja

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
---
2-
title: "Welcome to {{ 'Seedcase ' ~ (seedcase_short_name | title) if is_seedcase_project else package_name }}!"
2+
title: "Welcome!"
33
---

template/justfile.jinja

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
@_default:
22
just --list --unsorted
33

4-
@_checks: check-python check-unused test-python check-security check-spelling check-commits
4+
@_checks: check-python check-unused check-security check-spelling check-commits
55
@_tests: test-python
66
@_builds: build-contributors build-website build-readme
77

template/pyproject.toml.jinja

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,3 @@ issues = "https://github.com/{{ package_github_repo }}/issues"
2828
[build-system]
2929
requires = ["hatchling"]
3030
build-backend = "hatchling.build"
31-
32-
[tool.pytest.ini_options]
33-
addopts = [
34-
# A short traceback mode to make it easier to view
35-
"--tb=short",
36-
# Use the `src/` package
37-
"--import-mode=importlib",
38-
]

0 commit comments

Comments
 (0)