Fix asking project properties twice

Author: adrienlauer

CHANGELOG.md

@@ -1,3 +1,8 @@
+# Version 2.4.1 (2017-02-17)
+
+* [fix] Display the cause of the error when launching the application or a tool.
+* [fix] Fix asking for the generated project properties twice.
+
 # Version 2.4.0 (2017-02-09)
 
 * [new] New goal `effective-config` to dump effective configuration of the project as YAML.

pom.xml

@@ -19,7 +19,7 @@
 
     <groupId>org.seedstack</groupId>
     <artifactId>seedstack-maven-plugin</artifactId>
-    <version>2.4.0-SNAPSHOT</version>
+    <version>2.4.1-SNAPSHOT</version>
     <packaging>maven-plugin</packaging>
 
     <properties>

src/license/THIRD-PARTY.properties

@@ -12,7 +12,7 @@
 # Please fill the missing licenses for dependencies :
 #
 #
-#Thu Feb 09 18:02:08 CET 2017
+#Fri Feb 17 11:27:48 CET 2017
 classworlds--classworlds--1.1-alpha-2=
 commons-collections--commons-collections--3.1=
 dom4j--dom4j--1.6.1=

src/main/java/org/seedstack/maven/GenerateMojo.java

@@ -112,8 +112,7 @@ public void execute() throws MojoExecutionException, MojoFailureException {
             }
         }
 
-        // Using deprecated method to programmatically add a property to mojo execution
-        mavenSession.getExecutionProperties().setProperty("version", version);
+        mavenSession.getUserProperties().setProperty("version", version);
 
         String groupId = mavenSession.getUserProperties().getProperty("groupId");
         String artifactId = mavenSession.getUserProperties().getProperty("artifactId");
@@ -128,15 +127,16 @@ public void execute() throws MojoExecutionException, MojoFailureException {
             throw new MojoExecutionException("Generated project group id and artifact id are required", e);
         }
 
-        mavenSession.getExecutionProperties().put("groupId", groupId);
-        mavenSession.getExecutionProperties().put("artifactId", artifactId);
+        mavenSession.getUserProperties().put("groupId", groupId);
+        mavenSession.getUserProperties().put("artifactId", artifactId);
 
         String pluginVersion;
         try {
             pluginVersion = artifactResolver.getHighestVersion(mavenProject, ARCHETYPE_PLUGIN_GROUP_ID, ARCHETYPE_PLUGIN_ARTIFACT_ID, false);
+            getLog().info("Using the latest version of archetype plugin: " + pluginVersion);
         } catch (Exception e) {
-            getLog().warn("Unable to determine latest version of archetype plugin, falling back to 2.4");
-            pluginVersion = "2.4";
+            getLog().warn("Unable to determine latest version of archetype plugin, falling back to 3.0.0");
+            pluginVersion = "3.0.0";
         }
 
         executeMojo(plugin(groupId(ARCHETYPE_PLUGIN_GROUP_ID), artifactId(ARCHETYPE_PLUGIN_ARTIFACT_ID), version(pluginVersion)),

src/main/java/org/seedstack/maven/runnables/DefaultLauncherRunnable.java

@@ -59,7 +59,7 @@ private Object getSeedLauncher() throws Exception {
             Method getLauncherMethod = Thread.currentThread().getContextClassLoader().loadClass(SeedStackConstants.mainClassName).getMethod("getLauncher");
             return getLauncherMethod.invoke(null);
         } catch (Exception e) {
-            throw new MojoExecutionException("Seed application doesn't support launchers (you need at least Seed 2.1.0)");
+            throw new MojoExecutionException("Cannot launch SeedStack application", e);
         }
     }
 

src/main/java/org/seedstack/maven/runnables/ToolLauncherRunnable.java

@@ -56,7 +56,7 @@ private Object getToolLauncher() throws MojoExecutionException {
             Method getLauncherMethod = Thread.currentThread().getContextClassLoader().loadClass(SeedStackConstants.mainClassName).getMethod("getToolLauncher", String.class);
             return getLauncherMethod.invoke(null, tool);
         } catch (Exception e) {
-            throw new MojoExecutionException("Seed application doesn't support tools (you need at least Seed 3.0.0)");
+            throw new MojoExecutionException("Cannot launch SeedStack tool", e);
         }
     }