HookStack: Increase AWS SDK retries (#95)

I was initially looking at the adaptive strategy or a custom backoff
function, but I think this should be fine to begin with. The hook has
logic to try to short circuit if this all takes too long.

- https://docs.aws.amazon.com/sdkref/latest/guide/feature-retry-behavior.html
- https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/Package/-smithy-util-retry/
- https://github.com/seek-oss/aws-codedeploy-hooks/blob/714756b69539717fd25f4420c893f29f9b7fc317/packages/infra/src/handlers/index.ts#L20

Author: 72636c

.changeset/cold-adults-ring.md

@@ -0,0 +1,5 @@
+---
+'@seek/aws-codedeploy-infra': patch
+---
+
+HookStack: Increase AWS SDK retries

packages/infra/src/handlers/framework/aws.ts

@@ -1,12 +1,15 @@
-import { CodeDeployClient } from '@aws-sdk/client-codedeploy';
-import { LambdaClient } from '@aws-sdk/client-lambda';
+import {
+  CodeDeployClient,
+  type CodeDeployClientConfig,
+} from '@aws-sdk/client-codedeploy';
+import { LambdaClient, type LambdaClientConfig } from '@aws-sdk/client-lambda';
 
 import { config } from '../config';
 
 const clientConfig = {
-  maxAttempts: 5,
+  maxAttempts: 8,
   region: config.region,
-};
+} satisfies CodeDeployClientConfig & LambdaClientConfig;
 
 export const codeDeployClient = new CodeDeployClient(clientConfig);
 

packages/infra/src/handlers/process/lambda/prune.ts

@@ -2,12 +2,12 @@ import {
   type AliasConfiguration,
   DeleteFunctionCommand,
   type FunctionConfiguration,
-  LambdaClient,
   ListAliasesCommand,
   ListVersionsByFunctionCommand,
 } from '@aws-sdk/client-lambda';
 import { Env } from 'skuba-dive';
 
+import { lambdaClient } from '../../framework/aws';
 import { getContext } from '../../framework/context';
 import { logger } from '../../framework/logging';
 
@@ -17,8 +17,6 @@ type Args = Pick<LambdaFunction, 'name'>;
 
 const MAX_DELETIONS_PER_RUN = 20;
 
-const lambda = new LambdaClient();
-
 export const prune = async (fns: Args[]): Promise<void> => {
   await Promise.all(fns.map((fn) => pruneFunction(fn)));
 };
@@ -62,7 +60,7 @@ export const pruneFunction = async ({ name }: Args): Promise<void> => {
 
   await Promise.all(
     versionsToPrune.map((version) =>
-      lambda.send(
+      lambdaClient.send(
         new DeleteFunctionCommand({
           FunctionName: version.FunctionName,
           Qualifier: version.Version,
@@ -78,7 +76,7 @@ const listLambdaVersions = async (
   abortSignal?: AbortSignal,
   marker?: string,
 ): Promise<FunctionConfiguration[]> => {
-  const result = await lambda.send(
+  const result = await lambdaClient.send(
     new ListVersionsByFunctionCommand({
       FunctionName: functionName,
       Marker: marker,
@@ -105,7 +103,7 @@ const listAliases = async (
   abortSignal?: AbortSignal,
   marker?: string,
 ): Promise<AliasConfiguration[]> => {
-  const result = await lambda.send(
+  const result = await lambdaClient.send(
     new ListAliasesCommand({
       FunctionName: functionName,
       Marker: marker,