Remove duplicate updateTargetLambdaMetadata call

Author: zbrydon

packages/infra/src/handlers/framework/context.test.ts

@@ -172,4 +172,19 @@ describe('updateTargetLambdaMetadata', () => {
       expect(getContext().targetLambdaService).toBe('my-function');
     });
   });
+
+  it('does not throw if context is not available', () => {
+    const lambdaMetaData = {
+      Configuration: {
+        FunctionName: 'my-function',
+        Environment: {
+          Variables: {},
+        },
+      },
+      Tags: {},
+      $metadata: {},
+    };
+
+    expect(() => updateTargetLambdaMetadata(lambdaMetaData)).not.toThrow();
+  });
 });

packages/infra/src/handlers/process/lambda/prune.test.ts

@@ -2,7 +2,6 @@ import 'aws-sdk-client-mock-jest';
 
 import {
   DeleteFunctionCommand,
-  GetFunctionCommand,
   LambdaClient,
   ListAliasesCommand,
   ListVersionsByFunctionCommand,
@@ -25,15 +24,6 @@ afterEach(() => lambda.reset());
 
 describe('prune', () => {
   it('deletes versions from one function', async () => {
-    lambda.on(GetFunctionCommand).resolves({
-      Configuration: {
-        FunctionName: 'mock-name',
-      },
-      Tags: {
-        service: 'test-service',
-      },
-    });
-
     lambda
       .on(ListVersionsByFunctionCommand, { FunctionName: 'mock-name' })
       .resolves({
@@ -62,15 +52,6 @@ describe('prune', () => {
   });
 
   it('deletes versions from multiple functions', async () => {
-    lambda.on(GetFunctionCommand).resolves({
-      Configuration: {
-        FunctionName: 'mock-name',
-      },
-      Tags: {
-        service: 'test-service',
-      },
-    });
-
     lambda
       .on(ListVersionsByFunctionCommand, { FunctionName: 'mock-name-1' })
       .resolves({
@@ -119,15 +100,6 @@ describe('prune', () => {
   });
 
   it('paginates', async () => {
-    lambda.on(GetFunctionCommand).resolves({
-      Configuration: {
-        FunctionName: 'mock-name',
-      },
-      Tags: {
-        service: 'test-service',
-      },
-    });
-
     lambda
       .on(ListVersionsByFunctionCommand, {
         FunctionName: 'mock-name',
@@ -178,15 +150,6 @@ describe('prune', () => {
   });
 
   it('skips if nothing to delete', async () => {
-    lambda.on(GetFunctionCommand).resolves({
-      Configuration: {
-        FunctionName: 'mock-name',
-      },
-      Tags: {
-        service: 'test-service',
-      },
-    });
-
     lambda.on(ListVersionsByFunctionCommand).resolves({
       Versions: ['1', '2', '3', '4', '$LATEST'].map((Version) => ({
         Version,
@@ -204,15 +167,6 @@ describe('prune', () => {
   });
 
   it('handles empty responses', async () => {
-    lambda.on(GetFunctionCommand).resolves({
-      Configuration: {
-        FunctionName: 'mock-name',
-      },
-      Tags: {
-        service: 'test-service',
-      },
-    });
-
     lambda.on(ListVersionsByFunctionCommand).resolves({});
     lambda
       .on(ListAliasesCommand)

packages/infra/src/handlers/process/lambda/prune.ts

@@ -2,17 +2,13 @@ import {
   type AliasConfiguration,
   DeleteFunctionCommand,
   type FunctionConfiguration,
-  GetFunctionCommand,
   ListAliasesCommand,
   ListVersionsByFunctionCommand,
 } from '@aws-sdk/client-lambda';
 import { Env } from 'skuba-dive';
 
 import { lambdaClient } from '../../framework/aws.js';
-import {
-  getContext,
-  updateTargetLambdaMetadata,
-} from '../../framework/context.js';
+import { getContext } from '../../framework/context.js';
 import { logger } from '../../framework/logging.js';
 
 import type { LambdaFunction } from './types.js';
@@ -29,18 +25,11 @@ export const pruneFunction = async ({ name }: Args): Promise<void> => {
   const versionsToKeep = Env.nonNegativeInteger('VERSIONS_TO_KEEP');
   const { abortSignal } = getContext();
 
-  const getFunctionCommand = new GetFunctionCommand({
-    FunctionName: name,
-  });
-
-  const [aliases, versions, targetLambdaMetadata] = await Promise.all([
+  const [aliases, versions] = await Promise.all([
     listAliases(name, abortSignal),
     listLambdaVersions(name, abortSignal),
-    lambdaClient.send(getFunctionCommand),
   ]);
 
-  updateTargetLambdaMetadata(targetLambdaMetadata);
-
   const aliasMap = new Map(
     aliases.flatMap((alias) =>
       alias.FunctionVersion ? [[alias.FunctionVersion, alias]] : [],