30425 & 30422 - Bad request on large org_id & clean up logging for skip_404_logging (bcgov#3499)

Author: seeker25

auth-api/src/auth_api/resources/v1/org.py

@@ -60,14 +60,17 @@
 @_jwt.has_one_of_roles([Role.SYSTEM.value, Role.STAFF_VIEW_ACCOUNTS.value, Role.PUBLIC_USER.value])
 def search_organizations():
     """Search orgs."""
+    org_id = extract_numbers(request.args.get("id", None))
+    if org_id and org_id.isdigit() and int(org_id) >= 2147483647:
+        raise BusinessException(Error.INVALID_INPUT, None)
     org_search = OrgSearch(
         request.args.get("name", None),
         request.args.get("branchName", None),
         request.args.get("affiliation", None),
         request.args.getlist("status", None),
         request.args.getlist("accessType", None),
         request.args.get("bcolAccountId", None),
-        extract_numbers(request.args.get("id", None)),
+        org_id,
         request.args.get("decisionMadeBy", None),
         request.args.get("orgType", None),
         string_to_bool(request.args.get("includeMembers", "False")),

auth-api/src/auth_api/services/rest_service.py

@@ -219,7 +219,7 @@ def get(  # pylint: disable=too-many-positional-arguments,too-many-arguments
             current_app.logger.error(exc)
             raise ServiceUnavailableException(exc) from exc
         except HTTPError as exc:
-            if not (exc.response and exc.response.status_code == 404 and skip_404_logging):
+            if exc.response and exc.response.status_code == 404 and skip_404_logging is False:
                 current_app.logger.error(
                     f"HTTPError on GET {endpoint} "
                     f"with status code {exc.response.status_code if exc.response else ''}"

auth-api/update_poetry_dependencies.sh

@@ -32,7 +32,7 @@ urllib3 = "2.5.0"
 zipp = "3.19.1"
 
 # VCS dependencies
-auth-api = { git = "https://github.com/seeker25/sbc-auth.git", branch = "jinja_security_fix", subdirectory = "auth-api" }
+auth-api = { git = "https://github.com/bcgov/sbc-auth", branch = "30423", subdirectory = "auth-api" }
 simple-cloudevent = { git = "https://github.com/daxiom/simple-cloudevent.py.git" }
 cloud-sql-python-connector = "^1.13.0"
 pkginfo = "^1.12.1.2"

queue_services/account-mailer/poetry.lock

@@ -34,7 +34,7 @@ zipp = "3.19.1"
 
 
 # VCS dependencies
-auth-api = { git = "https://github.com/seeker25/sbc-auth.git", branch = "jinja_fix_p2", subdirectory = "auth-api" }
+auth-api = { git = "https://github.com/bcgov/sbc-auth", branch = "30423", subdirectory = "auth-api" }
 simple-cloudevent = { git = "https://github.com/daxiom/simple-cloudevent.py.git" }
 cloud-sql-python-connector = "^1.13.0"