address comment

wenxi-zeng · wenxi-zeng · commit 97ea40fbf822 · 2025-06-26T14:08:32.000-05:00
diff --git a/destination-filters-kotlin/src/main/java/com/segment/analytics/plugins/DestinationFilters.kt b/destination-filters-kotlin/src/main/java/com/segment/analytics/plugins/DestinationFilters.kt
@@ -75,8 +75,7 @@ class DestinationFilters : Plugin {
             cacheInvalidated = true
         }
 
-        // if engine recreated or rules are different we need to remove and recreated filters
-        // otherwise, we can skip
+        // If the engine has NOT been recreated and the cache/rules have not been invalidated then we can exit early.
         if (!engineRecreated && !cacheInvalidated) return
 
         metricsPlugin.setOfActiveDestinations.clear()

Original file line number	Diff line number	Diff line change
`@@ -75,8 +75,7 @@ class DestinationFilters : Plugin {`
`75`	`75`	`cacheInvalidated = true`
`76`	`76`	`}`
`77`	`77`
`78`		`- // if engine recreated or rules are different we need to remove and recreated filters`
`79`		`- // otherwise, we can skip`
	`78`	`+ // If the engine has NOT been recreated and the cache/rules have not been invalidated then we can exit early.`
`80`	`79`	`if (!engineRecreated && !cacheInvalidated) return`
`81`	`80`
`82`	`81`	`metricsPlugin.setOfActiveDestinations.clear()`