Fix issue while reading values from SEGGroupPayload in group() call (#90)

taruntyagi946 · migs647 · web-flow · commit 2e5a1ccd9e06 · 2021-04-15T13:45:40.000-07:00
* Fix issue while reading values from SEGGroupPayload in group() call

* Fix [Amplitude setGroup:groupName:] call in SEGAmplitudeIntegration

Co-authored-by: Cody Garvin &lt;emig647@gmail.com&gt;
diff --git a/Pod/Classes/SEGAmplitudeIntegration.m b/Pod/Classes/SEGAmplitudeIntegration.m
@@ -218,7 +218,7 @@ - (void)screen:(SEGScreenPayload *)payload
 - (void)group:(SEGGroupPayload *)payload
 {
     NSString *groupTypeTrait = self.settings[@"groupTypeTrait"];
-    NSString *groupTypeValue = self.settings[@"groupTypeValue"];
+    NSString *groupTypeValue = self.settings[@"groupValueTrait"];
     NSString *groupName = payload.traits[groupTypeTrait];
     NSString *groupValue = payload.traits[groupTypeValue];
 
@@ -227,7 +227,7 @@ - (void)group:(SEGGroupPayload *)payload
         groupValue = payload.groupId;
     }
 
-    [self.amplitude setGroup:groupValue groupName:groupName];
+    [self.amplitude setGroup:groupName groupName:groupValue];
     SEGLog(@"[Amplitude setGroup:%@ groupName:%@]", groupValue, groupName);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@ - (void)screen:(SEGScreenPayload *)payload`
`218`	`218`	`- (void)group:(SEGGroupPayload *)payload`
`219`	`219`	`{`
`220`	`220`	`NSString *groupTypeTrait = self.settings[@"groupTypeTrait"];`
`221`		`- NSString *groupTypeValue = self.settings[@"groupTypeValue"];`
	`221`	`+ NSString *groupTypeValue = self.settings[@"groupValueTrait"];`
`222`	`222`	`NSString *groupName = payload.traits[groupTypeTrait];`
`223`	`223`	`NSString *groupValue = payload.traits[groupTypeValue];`
`224`	`224`
`@@ -227,7 +227,7 @@ - (void)group:(SEGGroupPayload *)payload`
`227`	`227`	`groupValue = payload.groupId;`
`228`	`228`	`}`
`229`	`229`
`230`		`- [self.amplitude setGroup:groupValue groupName:groupName];`
	`230`	`+ [self.amplitude setGroup:groupName groupName:groupValue];`
`231`	`231`	`SEGLog(@"[Amplitude setGroup:%@ groupName:%@]", groupValue, groupName);`
`232`	`232`	`}`
`233`	`233`