fix issue related to not setting categories for the ConsentCategoryProvider. (#15)

Author: didiergarcia

.gitignore

@@ -6,4 +6,5 @@ build
 
 .idea
 lib/build
-local.properties
+local.properties
+.DS_Store

lib/src/main/java/com/segment/analytics/kotlin/destinations/consent/ConsentManager.kt

@@ -16,8 +16,10 @@ import com.segment.analytics.kotlin.destinations.consent.Constants.CONSENT_SETTI
 import com.segment.analytics.kotlin.destinations.consent.Constants.EVENT_SEGMENT_CONSENT_PREFERENCE
 import com.segment.analytics.kotlin.destinations.consent.Constants.HAS_UNMAPPED_DESTINATIONS_KEY
 import kotlinx.serialization.json.JsonArray
+import kotlinx.serialization.json.JsonElement
 import kotlinx.serialization.json.JsonPrimitive
 import kotlinx.serialization.json.buildJsonObject
+import kotlinx.serialization.json.jsonArray
 import kotlinx.serialization.json.jsonObject
 import sovran.kotlin.SynchronousStore
 import java.util.*
@@ -83,6 +85,9 @@ class ConsentManager(
             }
         }
 
+        // Add the list of categories to the Consent Category Provider so it knows which
+        // categories we care about.
+        this.consentProvider.setCategoryList(state.allCategories)
     }
 
     private fun consentStateFrom(settings: Settings): ConsentState {
@@ -106,9 +111,9 @@ class ConsentManager(
             }
         }
 
-        // Set hasUnmappedDestinations
+        // Set hasUnmappedDestinations and allCategories
         try {
-            settings.toJsonElement().jsonObject.get(CONSENT_SETTINGS_KEY)?.let {
+            settings.consentSettings.let {
                 it.jsonObject.getBoolean(HAS_UNMAPPED_DESTINATIONS_KEY)
                     ?.let { serverHasUnmappedDestinations ->
                         println("hasUnmappedDestinations jsonElement: $serverHasUnmappedDestinations")
@@ -117,7 +122,13 @@ class ConsentManager(
 
                 val allCategoriesJson = it.jsonObject.get(ALL_CATEGORIES_KEY)
                 allCategoriesJson?.let {
-                    it.jsonObject.values.forEach { jsonElement ->  allCategories.add(jsonElement.toString())}
+
+
+                    it.jsonArray.forEach { jsonElement ->
+
+                        if (jsonElement is JsonElement && jsonElement is JsonPrimitive) {
+                            allCategories.add(jsonElement.content)}
+                        }
                 }
             }
         } catch (t: Throwable) {

lib/src/test/kotlin/com/segment/analytics/kotlin/destinations/consent/ConsentManagerTests.kt

@@ -11,8 +11,10 @@ import com.segment.analytics.kotlin.core.platform.Plugin
 import com.segment.analytics.kotlin.core.utilities.LenientJson
 import com.segment.analytics.kotlin.core.utilities.toJsonElement
 import io.mockk.every
+import io.mockk.mockk
 import io.mockk.mockkStatic
 import io.mockk.spyk
+import io.mockk.verify
 import kotlinx.coroutines.test.TestScope
 import kotlinx.coroutines.test.UnconfinedTestDispatcher
 import kotlinx.serialization.json.JsonElement
@@ -246,4 +248,42 @@ class ConsentManagerTests {
         var resultingEvent = segmentBlocker.execute(event)
         assertNotNull(resultingEvent)
     }
-}
+
+    @Test
+    fun `ConsentManager calls ConsentCategoryProvider_setCategories() when update() is called`() {
+        val store = SynchronousStore()
+        store.provide(ConsentState.defaultState)
+        store.provide(
+            ConsentState(
+                mutableMapOf(),
+                true,
+                mutableListOf("foo"),
+                true)
+        )
+
+        val cp = mockk<ConsentCategoryProvider>()
+        every { cp.getCategories() } returns mapOf()
+        every { cp.setCategoryList(any())} returns Unit
+
+        val consentManager = ConsentManager(store, cp)
+
+        val settings = Settings(
+            integrations = emptyJsonObject,
+            plan = buildJsonObject { put("foo", JsonPrimitive("bar")) },
+            middlewareSettings = buildJsonObject { put("foo", JsonPrimitive("bar")) },
+            edgeFunction = buildJsonObject { put("foo", JsonPrimitive("bar")) },
+            consentSettings = buildJsonObject {
+                put(Constants.ALL_CATEGORIES_KEY, buildJsonArray {
+                    add(JsonPrimitive("foo"))
+                })
+                put(Constants.HAS_UNMAPPED_DESTINATIONS_KEY, JsonPrimitive(false))
+            }
+        )
+
+        consentManager.setup(analytics)
+        consentManager.update(settings, Plugin.UpdateType.Initial)
+
+        // Make sure we called setCategories was called.
+        verify { cp.setCategoryList(listOf("foo")) }
+    }
+}

testapp/src/main/java/com/segment/analytics/destinations/mydestination/testapp/MainApplication.kt

@@ -54,6 +54,7 @@ class MainApplication: Application() {
         val consentPlugin = ConsentManager(store, consentCategoryProvider)
 
         analytics.add(consentPlugin)
+        consentPlugin.start()
     }