Add validation for new setting

Author: harsh-joshi99

packages/destination-actions/src/destinations/google-enhanced-conversions/__tests__/google-enhanced-conversions.test.ts

@@ -8,6 +8,61 @@ const conversionTrackingId = '_conversion_id_'
 const conversionLabel = '_conversion_'
 
 describe('GoogleEnhancedConversions', () => {
+  describe('testAuthentication', () => {
+    it('should validate loginCustomerId format - valid format', async () => {
+      await expect(
+        testDestination.testAuthentication({
+          conversionTrackingId,
+          loginCustomerId: '123-456-7890'
+        })
+      ).resolves.not.toThrow()
+    })
+
+    it('should validate loginCustomerId format - valid format without dashes', async () => {
+      await expect(
+        testDestination.testAuthentication({
+          conversionTrackingId,
+          loginCustomerId: '1234567890'
+        })
+      ).resolves.not.toThrow()
+    })
+
+    it('should reject loginCustomerId with invalid format - too few digits', async () => {
+      await expect(
+        testDestination.testAuthentication({
+          conversionTrackingId,
+          loginCustomerId: '123-456-789'
+        })
+      ).rejects.toThrow('Login Customer ID must be 10 digits in XXX-XXX-XXXX format')
+    })
+
+    it('should reject loginCustomerId with invalid format - too many digits', async () => {
+      await expect(
+        testDestination.testAuthentication({
+          conversionTrackingId,
+          loginCustomerId: '123-456-78901'
+        })
+      ).rejects.toThrow('Login Customer ID must be 10 digits in XXX-XXX-XXXX format')
+    })
+
+    it('should reject loginCustomerId with invalid format - contains letters', async () => {
+      await expect(
+        testDestination.testAuthentication({
+          conversionTrackingId,
+          loginCustomerId: '123-456-789A'
+        })
+      ).rejects.toThrow('Login Customer ID must be 10 digits in XXX-XXX-XXXX format')
+    })
+
+    it('should allow empty/undefined loginCustomerId since it is optional', async () => {
+      await expect(
+        testDestination.testAuthentication({
+          conversionTrackingId
+        })
+      ).resolves.not.toThrow()
+    })
+  })
+
   describe('extendRequest - login-customer-id header', () => {
     it('should include login-customer-id header when loginCustomerId is provided', async () => {
       const event = createTestEvent({

packages/destination-actions/src/destinations/google-enhanced-conversions/index.ts

@@ -52,14 +52,27 @@ const destination: AudienceDestinationDefinition<Settings> = {
         type: 'string'
       }
     },
-    testAuthentication: async (_request) => {
+    testAuthentication: async (_request, { settings }) => {
       /* NOTE: Commenting this out until we surface the OAuth login flow in the Actions configuration wizard
       const res = await request<UserInfoResponse>('https://www.googleapis.com/oauth2/v3/userinfo', {
         method: 'GET'
       })
 
       return { name: res.data.name || res.data.email }
       */
+
+      // Validate loginCustomerId format if provided
+      if (settings.loginCustomerId) {
+        const cleanedId = settings.loginCustomerId.replace(/-/g, '')
+        if (!/^\d{10}$/.test(cleanedId)) {
+          throw new IntegrationError(
+            'Login Customer ID must be 10 digits in XXX-XXX-XXXX format',
+            'INVALID_LOGIN_CUSTOMER_ID',
+            400
+          )
+        }
+      }
+
       return true
     },
     refreshAccessToken: async (request, { auth }) => {