bug fixes post testing (#3136)

joe-ayoub-segment · web-flow · commit 9403c717c2f6 · 2025-08-05T08:56:54.000+01:00
diff --git a/packages/destination-actions/src/destinations/attentive/ecommEvent/__tests__/__snapshots__/snapshot.test.ts.snap b/packages/destination-actions/src/destinations/attentive/ecommEvent/__tests__/__snapshots__/snapshot.test.ts.snap
@@ -6,8 +6,10 @@ Object {
     Object {
       "name": "Test Product",
       "price": Array [
-        100,
-        "USD",
+        Object {
+          "currency": "USD",
+          "value": 100,
+        },
       ],
       "productId": "test-product-id",
       "productImage": "https://example.com/image.jpg",
@@ -33,8 +35,10 @@ Object {
     Object {
       "name": "Test Product",
       "price": Array [
-        100,
-        "USD",
+        Object {
+          "currency": "USD",
+          "value": 100,
+        },
       ],
       "productId": "test-product-id",
       "productImage": "https://example.com/image.jpg",
diff --git a/packages/destination-actions/src/destinations/attentive/ecommEvent/__tests__/index.test.ts b/packages/destination-actions/src/destinations/attentive/ecommEvent/__tests__/index.test.ts
@@ -64,7 +64,7 @@ describe('eCommerce API - Product View, Add to Cart, Purchase', () => {
           {
             productId: 'prod_1',
             productVariantId: 'variant_1',
-            price: [19.99, 'USD'],
+            price: [{ value: 19.99, currency: 'USD' }],
             productImage: 'https://example.com/image.png',
             productUrl: 'https://example.com/product/prod_1',
             name: 'Test Product',
@@ -122,7 +122,7 @@ describe('eCommerce API - Product View, Add to Cart, Purchase', () => {
           {
             productId: 'prod_1',
             productVariantId: 'variant_1',
-            price: [19.99, 'USD'],
+            price: [{ value: 19.99, currency: 'USD' }],
             productImage: 'https://example.com/image.png',
             productUrl: 'https://example.com/product/prod_1',
             name: 'Test Product',
@@ -180,7 +180,7 @@ describe('eCommerce API - Product View, Add to Cart, Purchase', () => {
           {
             productId: 'prod_1',
             productVariantId: 'variant_1',
-            price: [19.99, 'USD'],
+            price: [{ value: 19.99, currency: 'USD' }],
             productImage: 'https://example.com/image.png',
             productUrl: 'https://example.com/product/prod_1',
             name: 'Test Product',
diff --git a/packages/destination-actions/src/destinations/attentive/fields.ts b/packages/destination-actions/src/destinations/attentive/fields.ts
@@ -193,27 +193,13 @@ export const locale: InputField = {
   description: 'User locale. e.g. "en-US". Either Locale or Signup Source ID is required.',
   type: 'string',
   allowNull: false,
-  required: {
-    match: 'any',
-    conditions: [
-      { fieldKey: 'signUpSourceId', operator: 'is', value: undefined },
-      { fieldKey: 'signUpSourceId', operator: 'is', value: "" }
-    ]
-  },
   default: { '@path': '$.context.locale' }
 }
 
 export const signUpSourceId: InputField = {
   label: 'Signup Source ID',
   description: 'A unique identifier for the sign up source. Talk to your Attentive represenative. Either Locale or Signup Source ID is required.',
-  type: 'string',
-  required: {
-    match: 'any',
-    conditions: [
-      { fieldKey: 'locale', operator: 'is', value: undefined },
-      { fieldKey: 'locale', operator: 'is', value: "" }
-    ]
-  }
+  type: 'string'
 }
 
 export const singleOptIn: InputField = {
diff --git a/packages/destination-actions/src/destinations/attentive/functions.ts b/packages/destination-actions/src/destinations/attentive/functions.ts
@@ -53,7 +53,7 @@ function formatUser(userIdentifiers: UserIdentifiers): User {
 function formatItems(items: Items): Array<Item> {
   return items.map(({ value, currency, ...rest }) => ({
     ...rest,
-    price: currency !== undefined && currency !== null && currency !== '' ? [value, currency] : [value]
+    price: currency !== undefined && currency !== null && currency !== '' ? [{value, currency}] : [{value}]
   }))
 }
 
diff --git a/packages/destination-actions/src/destinations/attentive/subscribeUser/__tests__/__snapshots__/snapshot.test.ts.snap b/packages/destination-actions/src/destinations/attentive/subscribeUser/__tests__/__snapshots__/snapshot.test.ts.snap
@@ -27,7 +27,6 @@ Object {
     "country": "US",
     "language": "en",
   },
-  "signUpSourceId": "*Cc5M#wXxFe",
   "subscriptionType": "MARKETING",
   "user": Object {
     "externalIdentifiers": Object {
diff --git a/packages/destination-actions/src/destinations/attentive/types.ts b/packages/destination-actions/src/destinations/attentive/types.ts
@@ -43,7 +43,7 @@ export interface Item {
   productImage?: string
   productUrl?: string
   name?: string
-  price: [value: number, currency?: string]
+  price: [{value: number, currency?: string}]
   quantity?: number
 }
 export type SubscriptionType = typeof SUBSCRIPTION_TYPES[number]

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ function formatUser(userIdentifiers: UserIdentifiers): User {`
`53`	`53`	`function formatItems(items: Items): Array<Item> {`
`54`	`54`	`return items.map(({ value, currency, ...rest }) => ({`
`55`	`55`	`...rest,`
`56`		`- price: currency !== undefined && currency !== null && currency !== '' ? [value, currency] : [value]`
	`56`	`+ price: currency !== undefined && currency !== null && currency !== '' ? [{value, currency}] : [{value}]`
`57`	`57`	`}))`
`58`	`58`	`}`
`59`	`59`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ export interface Item {`
`43`	`43`	`productImage?: string`
`44`	`44`	`productUrl?: string`
`45`	`45`	`name?: string`
`46`		`- price: [value: number, currency?: string]`
	`46`	`+ price: [{value: number, currency?: string}]`
`47`	`47`	`quantity?: number`
`48`	`48`	`}`
`49`	`49`	`export type SubscriptionType = typeof SUBSCRIPTION_TYPES[number]`