Skip to content

Commit 9bd27c7

Browse files
committed
Merge branch 'tier-1-batch-4' into staging
# Conflicts: # packages/destination-actions/src/destinations/amazon-amc/function.ts # packages/destination-actions/src/destinations/amazon-amc/index.ts
2 parents 8a06b5b + 36e6e89 commit 9bd27c7

File tree

13 files changed

+59
-14
lines changed

13 files changed

+59
-14
lines changed

packages/destination-actions/src/destinations/amazon-amc/function.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import type { Payload } from './syncAudiencesToDSP/generated-types'
1010
import { AudienceRecord, HashedPIIObject, RecordsResponseType } from './types'
1111
import { processHashing } from '../../lib/hashing-utils'
1212
import { CONSTANTS, REGEX_EXTERNALUSERID, ALPHA_NUMERIC, EMAIL_ALLOWED, NON_DIGIT, SYNC_TO } from './constants'
13+
import { AMAZON_AMC_API_VERSION } from './versioning-info'
1314

1415
export async function processPayload(
1516
request: RequestClient,
@@ -25,7 +26,7 @@ export async function processPayload(
2526
method: 'POST',
2627
body: payloadString,
2728
headers: {
28-
'Content-Type': 'application/vnd.amcaudiences.v1+json'
29+
'Content-Type': `application/vnd.amcaudiences.${AMAZON_AMC_API_VERSION}+json`
2930
},
3031
timeout: 15000
3132
})

packages/destination-actions/src/destinations/amazon-amc/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ const destination: AudienceDestinationDefinition<Settings, AudienceSettings> = {
4343
}
4444

4545
try {
46-
await request<RefreshTokenResponse>(`${settings.region}/v2/profiles`, {
46+
await request<RefreshTokenResponse>(`${settings.region}/${AMAZON_AMC_AUTH_API_VERSION}/profiles`, {
4747
method: 'GET',
4848
headers: {
4949
'Content-Type': 'application/json'
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
/** AMAZON_AMC_API_VERSION
2+
* Audience media type: application/vnd.amcaudiences.v1+json
3+
* API reference: https://advertising.amazon.com/API/docs/en-us/amc-advertiser-audience#tag/Audience%20Records/operation/ManageAudienceV2
4+
*/
5+
export const AMAZON_AMC_API_VERSION = 'v1'
6+
7+
/** AMAZON_AMC_AUTH_API_VERSION
8+
* API reference: https://advertising.amazon.com/API/docs/en-us/reference/2/profiles#tag/Profiles/operation/listProfiles
9+
* Auth profiles endpoint: /amc/v2/profiles
10+
*/
11+
export const AMAZON_AMC_AUTH_API_VERSION = 'v2'

packages/destination-actions/src/destinations/display-video-360/constants.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
export const GOOGLE_API_VERSION = 'v2'
1+
import { DISPLAY_VIDEO_360_AUDIENCE_PARTNER_API_VERSION } from './versioning-info'
2+
23
// accountType and advertiserID are used as markers to be replaced in the code. DO NOT REMOVE THEM.
3-
export const BASE_URL = `https://audiencepartner.googleapis.com/${GOOGLE_API_VERSION}/products/accountType/customers/advertiserID/`
4+
export const BASE_URL = `https://audiencepartner.googleapis.com/${DISPLAY_VIDEO_360_AUDIENCE_PARTNER_API_VERSION}/products/accountType/customers/advertiserID/`
45
export const CREATE_AUDIENCE_URL = `${BASE_URL}userLists:mutate`
56
export const GET_AUDIENCE_URL = `${BASE_URL}audiencePartner:searchStream`
67
export const OAUTH_URL = 'https://accounts.google.com/o/oauth2/token'
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
/** DISPLAY_VIDEO_360_AUDIENCE_PARTNER_API_VERSION
2+
* DV360 Audience Partner API base version.
3+
* API reference: https://developers.google.com/audience-partner/api/reference/rest/v2/products.customers.audiencePartner/searchStream?hl=en
4+
* The above link references the v2 version of the API and is confidential.
5+
*/
6+
export const DISPLAY_VIDEO_360_AUDIENCE_PARTNER_API_VERSION = 'v2'

packages/destination-actions/src/destinations/linkedin-conversions/constants.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { DependsOnConditions } from '@segment/actions-core/destination-kit/types'
2+
import { LINKEDIN_CONVERSIONS_API_VERSION } from './versioning-info'
23

3-
export const LINKEDIN_API_VERSION = '202505'
4+
export const LINKEDIN_API_VERSION = LINKEDIN_CONVERSIONS_API_VERSION
45
export const BASE_URL = 'https://api.linkedin.com/rest'
56
export const LINKEDIN_SOURCE_PLATFORM = 'SEGMENT'
67

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
/** LINKEDIN_CONVERSIONS_API_VERSION
2+
* LinkedIn Conversions API version.
3+
* API reference: https://learn.microsoft.com/en-us/linkedin/marketing/integrations/ads-reporting/conversions-api?view=li-lms-2025-05&tabs=curl
4+
*/
5+
export const LINKEDIN_CONVERSIONS_API_VERSION = '202505'

packages/destination-actions/src/destinations/reddit-audiences/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { defaultValues, AudienceDestinationDefinition } from '@segment/actions-c
22
import type { Settings, AudienceSettings } from './generated-types'
33
import syncAudience from './syncAudience'
44
import { CreateAudienceReq, CreateAudienceResp } from './types'
5+
import { REDDIT_AUDIENCES_AUTH_API_VERSION } from './versioning-info'
56

67
const destination: AudienceDestinationDefinition<Settings, AudienceSettings> = {
78
name: 'Reddit Audiences',
@@ -20,7 +21,7 @@ const destination: AudienceDestinationDefinition<Settings, AudienceSettings> = {
2021
refreshAccessToken: async (request, { auth }) => {
2122
const authToken = Buffer.from(`${auth.clientId}:${auth.clientSecret}`).toString('base64')
2223

23-
const res = await request('https://www.reddit.com/api/v1/access_token', {
24+
const res = await request(`https://www.reddit.com/api/${REDDIT_AUDIENCES_AUTH_API_VERSION}/access_token`, {
2425
method: 'POST',
2526
headers: {
2627
Authorization: `Basic ${authToken}`,

packages/destination-actions/src/destinations/reddit-audiences/syncAudience/functions.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { UpdateAudienceReq, Columns } from '../types'
44
import { EMAIL_SCHEMA_NAME, MAID_SCHEMA_NAME } from '../const'
55
// eslint-disable-next-line no-restricted-syntax
66
import { createHash } from 'crypto'
7+
import { REDDIT_AUDIENCES_ADS_API_VERSION } from '../versioning-info'
78

89
export async function send(request: RequestClient, payloads: Payload[]) {
910
const audienceId = payloads[0].external_audience_id
@@ -89,10 +90,13 @@ function getColumns(payloads: Payload[]): Columns {
8990
}
9091

9192
async function updateAudience(request: RequestClient, json: UpdateAudienceReq, audienceid: string) {
92-
return await request<UpdateAudienceReq>(`https://ads-api.reddit.com/api/v3/custom_audiences/${audienceid}/users`, {
93-
method: 'PATCH',
94-
json
95-
})
93+
return await request<UpdateAudienceReq>(
94+
`https://ads-api.reddit.com/api/${REDDIT_AUDIENCES_ADS_API_VERSION}/custom_audiences/${audienceid}/users`,
95+
{
96+
method: 'PATCH',
97+
json
98+
}
99+
)
96100
}
97101

98102
function ensureHashed(value: string): boolean {
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
/** REDDIT_AUDIENCES_AUTH_API_VERSION
2+
* path /api/v1/access_token
3+
* API reference: https://ads-api.reddit.com/docs/v3/#authenticate-your-developer-application
4+
*/
5+
export const REDDIT_AUDIENCES_AUTH_API_VERSION = 'v1'
6+
7+
/** REDDIT_AUDIENCES_ADS_API_VERSION
8+
* path custom_audiences/${audienceid}/users
9+
* API reference: https://ads-api.reddit.com/docs/v3/
10+
*/
11+
export const REDDIT_AUDIENCES_ADS_API_VERSION = 'v3'

0 commit comments

Comments
 (0)