Merge branch 'main' into liquid-templates-metrics

Author: joe-ayoub-segment

.eslintrc.js

@@ -47,7 +47,8 @@ module.exports = {
     '@typescript-eslint/restrict-template-expressions': 'off',
     '@typescript-eslint/unbound-method': 'off',
     '@typescript-eslint/no-unsafe-argument': 'warn',
-    '@typescript-eslint/no-misused-promises': 'warn'
+    '@typescript-eslint/no-misused-promises': 'warn',
+    '@typescript-eslint/no-unnecessary-type-assertion': 'warn'
   },
   overrides: [
     {

.github/copilot-instructions.md

@@ -0,0 +1,33 @@
+# Copilot Instructions
+
+This document provides instructions for GitHub Copilot to assist with reviewing pull requests and performing tasks based on user prompts. It references existing guidelines and role-specific instructions available in this repository.
+
+## Understanding the repository
+
+Read the [README](../README.md) to understand the purpose of this repository and its structure. On high level, this repository contains the following key packages:
+
+- [`action-destinations`](../packages/destination-actions): This contains all cloud-mode destinations. All new destinations are registered manually and the destination metadata id is then updated in [index.ts](../packages/destination-actions/src/index.ts).
+- [`browser-destinations`](../packages/browser-destinations): This contains all browser-mode destinations. All new destinations are registered manually and the destination metadata id is then updated in [destination-manifest/index.ts](../packages/destinations-manifest/src/index.ts).
+- [`core`](../packages/core): This contains all the core framework for running the destinations. Any changes made here will affect both cloud-mode and browser-mode destinations. Thorough regression testing is required for these changes.
+- [`destination-subscriptions`](../packages/destination-subscriptions): This package validates event payloads against an action's subscription AST.
+- [`browser-destination-runtime`](../packages/browser-destination-runtime): This package contains the runtime for browser-mode destinations, including the logic for executing actions and handling events.
+
+## Reviewing Pull Requests
+
+When reviewing pull requests, Copilot should:
+
+1. Ensure all the required checks mentioned [here](../docs/pr-guidelines/pr-checks.md) have passed.
+2. Follow the expectations outlined in the [Reviewer Guidelines](../docs/pr-guidelines/pull-request-guidance.md).
+3. Suggest splitting changes to multiple destinations into separate pull requests.
+4. Ensure that the pull request doesn't introduce known breaking changes as called out in the [Pull Request Guidance](../docs/pr-guidelines/pull-request-guidance.md).
+
+## Performing Tasks
+
+When performing tasks based on user prompts, Copilot should:
+
+1. Refer to the relevant guidelines and documentation in this repository.
+2. Ensure that any code changes follow the principles outlined in the [Contributor Guidelines](../docs/pr-guidelines/pull-request-guidance.md).
+3. Ensure that code changes are implemented using as many framework features as possible, such as conditionally required fields, error handling etc.
+4. Write clear unit tests for any new functionality or changes made to existing functionality.
+   - Use the existing tests as a reference for writing new tests.
+   - All external calls should be mocked in the tests. For cloud-mode destinations, we use `nock` to mock external calls.

docs/pr-guidelines/pr-checks.md

@@ -0,0 +1,12 @@
+# PR CI Checks
+
+The following checks should pass for all PRs:
+
+- CI / Unit Tests
+- CI / Lint
+- CI / Validate
+- CI / Browser Destination Bundle QA
+- CI / Browser tests: actions-core
+- Required Field Check / required-field-check
+- Test External
+- codecov

docs/pr-guidelines/pull-request-guidance.md

@@ -0,0 +1,7 @@
+# PR request guidelines
+
+- The pull request includes a description of testing performed.
+- The pull request doesn't introduce a new required field to an already existing action definition. This will result in failures for existing customers.
+- Ensure errors are handled as per [error-guidelines](../docs/error-handling.md).
+- Ensure the pull request uses framework features such as [Conditionally required fields](https://github.com/segmentio/action-destinations?tab=readme-ov-file#required-fields)
+- Check for grammatical and spelling mistakes in descriptions for Action Definition fields and Destination Definition settings.

package.json

@@ -54,7 +54,7 @@
     "eslint-plugin-lodash": "^7.3.0",
     "express": "^4.18.2",
     "husky": "^7.0.0",
-    "jest": "^27.3.1",
+    "jest": "^30.0.3",
     "jest-browser-globals": "^25.1.0-beta",
     "jest-mock": "^29.3.1",
     "karma": "^6.4.1",
@@ -74,7 +74,7 @@
     "timers-browserify": "^2.0.12",
     "ts-jest": "^27.0.7",
     "ts-node": "^9.1.1",
-    "typescript": "4.9.5",
+    "typescript": "5.5.4",
     "ws": "^8.5.0"
   },
   "resolutions": {

packages/actions-shared/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@segment/actions-shared",
   "description": "Shared destination action methods and definitions.",
-  "version": "1.137.0",
+  "version": "1.138.0",
   "repository": {
     "type": "git",
     "url": "https://github.com/segmentio/action-destinations",
@@ -37,7 +37,7 @@
   },
   "dependencies": {
     "@amplitude/ua-parser-js": "^0.7.25",
-    "@segment/actions-core": "^3.156.0",
+    "@segment/actions-core": "^3.157.0",
     "cheerio": "^1.0.0-rc.10",
     "dayjs": "^1.10.7",
     "escape-goat": "^3",

packages/browser-destination-runtime/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@segment/browser-destination-runtime",
-  "version": "1.85.0",
+  "version": "1.86.0",
   "license": "MIT",
   "publishConfig": {
     "access": "public",
@@ -62,7 +62,7 @@
     }
   },
   "dependencies": {
-    "@segment/actions-core": "^3.156.0"
+    "@segment/actions-core": "^3.157.0"
   },
   "devDependencies": {
     "@segment/analytics-next": "*"

packages/browser-destinations/destinations/1flow/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@segment/analytics-browser-actions-1flow",
-  "version": "1.68.0",
+  "version": "1.69.0",
   "license": "MIT",
   "publishConfig": {
     "access": "public",
@@ -15,7 +15,7 @@
   },
   "typings": "./dist/esm",
   "dependencies": {
-    "@segment/browser-destination-runtime": "^1.85.0"
+    "@segment/browser-destination-runtime": "^1.86.0"
   },
   "peerDependencies": {
     "@segment/analytics-next": ">=1.55.0"

packages/browser-destinations/destinations/adobe-target/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@segment/analytics-browser-actions-adobe-target",
-  "version": "1.87.0",
+  "version": "1.88.0",
   "license": "MIT",
   "publishConfig": {
     "access": "public",
@@ -16,7 +16,7 @@
   },
   "typings": "./dist/esm",
   "dependencies": {
-    "@segment/browser-destination-runtime": "^1.85.0"
+    "@segment/browser-destination-runtime": "^1.86.0"
   },
   "peerDependencies": {
     "@segment/analytics-next": ">=1.55.0"

packages/browser-destinations/destinations/algolia-plugins/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@segment/analytics-browser-actions-algolia-plugins",
-  "version": "1.63.0",
+  "version": "1.64.0",
   "license": "MIT",
   "publishConfig": {
     "access": "public",
@@ -15,7 +15,7 @@
   },
   "typings": "./dist/esm",
   "dependencies": {
-    "@segment/browser-destination-runtime": "^1.85.0"
+    "@segment/browser-destination-runtime": "^1.86.0"
   },
   "peerDependencies": {
     "@segment/analytics-next": ">=1.55.0"