fix(algolia-insights): allow click position of 0 (#3513)

* fix(algolia-insights): allow click position of 0

* update description

* resolve: yarn types

Author: jkaho

packages/destination-actions/src/destinations/algolia-insights/productClickedEvents/__tests__/index.test.ts

@@ -144,4 +144,19 @@ describe('AlgoliaInsights.productClickedEvents', () => {
     expect(algoliaEvent.userToken).toBe(event.anonymousId)
     expect(algoliaEvent.authenticatedUserToken).toBe(event.userId)
   })
+
+  it('should pass position if 0', async () => {
+    const event = createTestEvent({
+      type: 'track',
+      event: 'Product Clicked',
+      properties: {
+        query_id: '1234',
+        search_index: 'fashion_1',
+        product_id: '9876',
+        position: 0
+      }
+    })
+    const algoliaEvent = await testAlgoliaDestination(event)
+    expect(algoliaEvent.positions?.[0]).toBe(event.properties?.position)
+  })
 })

packages/destination-actions/src/destinations/algolia-insights/productClickedEvents/generated-types.ts

@@ -41,7 +41,7 @@ export const productClickedEvents: ActionDefinition<Settings, Payload> = {
     },
     position: {
       label: 'Position',
-      description: 'Position of the click in the list of Algolia search results.',
+      description: 'Position of the click in the list of Algolia search results. Positions should start from 1, not 0.',
       type: 'integer',
       required: false,
       default: {
@@ -116,7 +116,7 @@ export const productClickedEvents: ActionDefinition<Settings, Payload> = {
       objectIDs: [data.payload.objectID],
       userToken: data.payload.userToken,
       authenticatedUserToken: data.payload.authenticatedUserToken,
-      positions: data.payload.position ? [data.payload.position] : undefined,
+      positions: data.payload.position != null ? [data.payload.position] : undefined,
       timestamp: data.payload.timestamp ? new Date(data.payload.timestamp).valueOf() : undefined
     }
     const insightPayload = { events: [insightEvent] }