Skip to content

Commit cbbb5f6

Browse files
STRATCONN-6441 - [Facebook CAPI] - Append Event functionality and refactor (#3556)
* clean branch commit * removing bad files * field render mode change * making original_event_time required for append value events * adding partner_agent string to all events * Add ctwa_clid in user data of fb conversions apis (#3611) * fixing unit tests * fixing lint issue with test --------- Co-authored-by: harsh-joshi99 <129737395+harsh-joshi99@users.noreply.github.com>
1 parent b8ed678 commit cbbb5f6

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+4190
-2583
lines changed

packages/destination-actions/src/destinations/facebook-conversions-api/__tests__/addToCart.test.ts

Lines changed: 61 additions & 11 deletions
Large diffs are not rendered by default.

packages/destination-actions/src/destinations/facebook-conversions-api/__tests__/addToCart2.test.ts

Lines changed: 62 additions & 11 deletions
Large diffs are not rendered by default.

packages/destination-actions/src/destinations/facebook-conversions-api/__tests__/app-data.test.ts

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
import { generate_app_data, AppData, GeneratedAppData } from '../fb-capi-app-data'
1+
import { generateAppData } from '../functions'
2+
import { AnyPayload, GeneratedAppData } from '../types'
23

34
describe('FacebookConversionsApi', () => {
45
describe('AppData', () => {
5-
const sampleAppDataComplete: AppData = {
6+
const sampleAppDataComplete: AnyPayload['app_data_field'] = {
67
use_app_data: true,
78
advertiser_tracking_enabled: true,
89
application_tracking_enabled: true,
@@ -23,7 +24,7 @@ describe('FacebookConversionsApi', () => {
2324
freeStorage: '64',
2425
deviceTimezone: 'America/Los_Angeles'
2526
}
26-
const sampleAppDataIncomplete: AppData = {
27+
const sampleAppDataIncomplete: AnyPayload['app_data_field'] = {
2728
...sampleAppDataComplete
2829
}
2930
delete sampleAppDataIncomplete.timezone
@@ -33,28 +34,28 @@ describe('FacebookConversionsApi', () => {
3334
// app data should always have a length 16 array. Do not change this without first verifying something has changed with facebook.
3435
// A previous issue arose where we sent length 18 arrays and event delivery silently failed.
3536
it('generated app data should always have a length 16 exinfo array', () => {
36-
let appData: GeneratedAppData | undefined = generate_app_data(sampleAppDataComplete)
37+
let appData: GeneratedAppData | undefined = generateAppData(sampleAppDataComplete)
3738
if (appData) {
3839
expect(appData.extinfo.length).toBe(16)
3940
}
4041
expect(appData).toBeDefined()
4142

42-
appData = generate_app_data(sampleAppDataIncomplete)
43+
appData = generateAppData(sampleAppDataIncomplete)
4344
if (appData) {
4445
expect(appData.extinfo.length).toBe(16)
4546
}
4647
expect(appData).toBeDefined()
4748
})
4849

4950
it('generated app data should be undefined if use_app_data is false', () => {
50-
const appData = generate_app_data({
51+
const appData = generateAppData({
5152
use_app_data: false
5253
})
5354
expect(appData).toBeUndefined()
5455
})
5556

5657
it('generated app data should include empty strings if fields are missing from extinfo', () => {
57-
const appData = generate_app_data(sampleAppDataIncomplete)
58+
const appData = generateAppData(sampleAppDataIncomplete)
5859
if (appData) {
5960
expect(appData.advertiser_tracking_enabled).toBe(1)
6061
expect(appData.application_tracking_enabled).toBe(1)

0 commit comments

Comments
 (0)