Skip to content

STRATCONN-5946 - [Taguchi] - new Destination #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

STRATCONN-5946 - [Taguchi] - new Destination #3014

wants to merge 5 commits into from

Conversation

joe-ayoub-segment
Copy link
Contributor

@joe-ayoub-segment joe-ayoub-segment commented Jun 19, 2025 •
edited
Loading

New Destination for Taguchi

Testing

Unit tests added.
Will be tested in Private Beta

@joe-ayoub-segment joe-ayoub-segment self-assigned this Jun 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 19, 2025 •
edited
Loading

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Taguchi, Settings:apiKey,integrationURL,organizationId
  • Destination: Taguchi, Action:syncEvent, Fields:target,eventType
  • Destination: Taguchi, Action:syncUserProfile, Fields:identifiers,timestamp

Add these new fields as optional instead and assume default values in perform or performBatch block.

@joe-ayoub-segment joe-ayoub-segment marked this pull request as ready for review August 28, 2025 12:11
@joe-ayoub-segment joe-ayoub-segment requested a review from a team as a code owner August 28, 2025 12:11
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 95.83333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.70%. Comparing base (20511c2) to head (b893563).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...ctions/src/destinations/taguchi/syncEvent/utils.ts 91.30% 1 Missing and 1 partial ⚠️
.../src/destinations/taguchi/syncUserProfile/utils.ts 95.65% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3014      +/-   ##
==========================================
- Coverage   79.81%   79.70%   -0.12%     
==========================================
  Files        1165     1184      +19     
  Lines       21513    21799     +286     
  Branches     4154     4246      +92     
==========================================
+ Hits        17171    17374     +203     
- Misses       3627     3681      +54     
- Partials      715      744      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayan-das-in sayan-das-in sayan-das-in approved these changes

@harsh-joshi99 harsh-joshi99 harsh-joshi99 approved these changes

Assignees

@joe-ayoub-segment joe-ayoub-segment

Labels
deploy:push deploy:registration mode:cloud partner-eng-review (cloud) Ready for Release team:segment-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joe-ayoub-segment @sayan-das-in @harsh-joshi99