From 028498755c8168ec2c25d283c0fa95d92a7efe98 Mon Sep 17 00:00:00 2001 From: Md Mozammil Khan Date: Mon, 6 Oct 2025 16:19:07 +0530 Subject: [PATCH 1/3] removing not applicable settings implementation --- .../src/destinations/kafka/utils.ts | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/packages/destination-actions/src/destinations/kafka/utils.ts b/packages/destination-actions/src/destinations/kafka/utils.ts index e6d31e3d82..7466812e23 100644 --- a/packages/destination-actions/src/destinations/kafka/utils.ts +++ b/packages/destination-actions/src/destinations/kafka/utils.ts @@ -19,9 +19,6 @@ export const serializeKafkaConfig = (settings: Settings): string => { mechanism: settings.mechanism, username: settings.username, password: settings.password, - accessKeyId: settings.accessKeyId, - secretAccessKey: settings.secretAccessKey, - authorizationIdentity: settings.authorizationIdentity, ssl_ca: settings.ssl_ca, ssl_cert: settings.ssl_cert, ssl_key: settings.ssl_key, @@ -64,13 +61,6 @@ const getKafka = (settings: Settings) => { password: settings.password, mechanism: settings.mechanism } as SASLOptions - case 'aws': - return { - accessKeyId: settings.accessKeyId, - secretAccessKey: settings.secretAccessKey, - authorizationIdentity: settings.authorizationIdentity, - mechanism: settings.mechanism - } as SASLOptions default: return undefined } @@ -118,13 +108,6 @@ export const validate = (settings: Settings) => { 400 ) } - if (['aws'].includes(settings.mechanism) && (!settings.accessKeyId || !settings.secretAccessKey)) { - throw new IntegrationError( - 'AWS Access Key ID and AWS Secret Key are required for AWS authentication mechanism', - 'SASL_AWS_PARAMS_MISSING', - 400 - ) - } if (['client-cert-auth'].includes(settings.mechanism) && (!settings.ssl_key || !settings.ssl_cert)) { throw new IntegrationError( 'SSL Client Key and SSL Client Certificate are required for Client Certificate authentication mechanism', From 89a5f755573654a318fac9b052f869ee3bf95f92 Mon Sep 17 00:00:00 2001 From: Md Mozammil Khan Date: Mon, 6 Oct 2025 16:05:24 +0530 Subject: [PATCH 2/3] removing IAM authentication mechanism for kafka --- .../src/destinations/kafka/index.ts | 25 ------------------- 1 file changed, 25 deletions(-) diff --git a/packages/destination-actions/src/destinations/kafka/index.ts b/packages/destination-actions/src/destinations/kafka/index.ts index 312009dde7..ed737a7abb 100644 --- a/packages/destination-actions/src/destinations/kafka/index.ts +++ b/packages/destination-actions/src/destinations/kafka/index.ts @@ -36,7 +36,6 @@ const destination: DestinationDefinition = { { label: 'Plain', value: 'plain' }, { label: 'SCRAM-SHA-256', value: 'scram-sha-256' }, { label: 'SCRAM-SHA-512', value: 'scram-sha-512' }, - // { label: 'AWS IAM', value: 'aws' }, { label: 'Client Certificate', value: 'client-cert-auth' } ], default: 'plain' @@ -57,30 +56,6 @@ const destination: DestinationDefinition = { required: false, depends_on: DEPENDS_ON_PLAIN_OR_SCRAM }, - accessKeyId: { - label: 'AWS Access Key ID', - description: - 'The Access Key ID for your AWS IAM instance. Must be populated if using AWS IAM Authentication Mechanism.', - type: 'string', - required: false, - depends_on: DEPEONDS_ON_AWS - }, - secretAccessKey: { - label: 'AWS Secret Key', - description: - 'The Secret Key for your AWS IAM instance. Must be populated if using AWS IAM Authentication Mechanism.', - type: 'password', - required: false, - depends_on: DEPEONDS_ON_AWS - }, - authorizationIdentity: { - label: 'AWS Authorization Identity', - description: - 'AWS IAM role ARN used for authorization. This field is optional, and should only be populated if using the AWS IAM Authentication Mechanism.', - type: 'string', - required: false, - depends_on: DEPEONDS_ON_AWS - }, ssl_enabled: { label: 'SSL Enabled', description: 'Indicates if SSL should be enabled.', From 1f5e5eaa2db376bcdefd2d4c348d8b4fed328a3e Mon Sep 17 00:00:00 2001 From: Md Mozammil Khan Date: Tue, 7 Oct 2025 11:49:52 +0530 Subject: [PATCH 3/3] remove unused import --- .../src/destinations/kafka/generated-types.ts | 12 ------------ .../src/destinations/kafka/index.ts | 2 +- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/packages/destination-actions/src/destinations/kafka/generated-types.ts b/packages/destination-actions/src/destinations/kafka/generated-types.ts index 5e2cb813af..316ef35019 100644 --- a/packages/destination-actions/src/destinations/kafka/generated-types.ts +++ b/packages/destination-actions/src/destinations/kafka/generated-types.ts @@ -21,18 +21,6 @@ export interface Settings { * The password for your Kafka instance. Should only be populated if using PLAIN or SCRAM Authentication Mechanisms. */ password?: string - /** - * The Access Key ID for your AWS IAM instance. Must be populated if using AWS IAM Authentication Mechanism. - */ - accessKeyId?: string - /** - * The Secret Key for your AWS IAM instance. Must be populated if using AWS IAM Authentication Mechanism. - */ - secretAccessKey?: string - /** - * AWS IAM role ARN used for authorization. This field is optional, and should only be populated if using the AWS IAM Authentication Mechanism. - */ - authorizationIdentity?: string /** * Indicates if SSL should be enabled. */ diff --git a/packages/destination-actions/src/destinations/kafka/index.ts b/packages/destination-actions/src/destinations/kafka/index.ts index ed737a7abb..fc749dc9b3 100644 --- a/packages/destination-actions/src/destinations/kafka/index.ts +++ b/packages/destination-actions/src/destinations/kafka/index.ts @@ -1,7 +1,7 @@ import type { DestinationDefinition } from '@segment/actions-core' import type { Settings } from './generated-types' import { validate, getTopics } from './utils' -import { DEPENDS_ON_CLIENT_CERT, DEPEONDS_ON_AWS, DEPENDS_ON_PLAIN_OR_SCRAM } from './depends-on' +import { DEPENDS_ON_CLIENT_CERT, DEPENDS_ON_PLAIN_OR_SCRAM } from './depends-on' import send from './send' const destination: DestinationDefinition = {