Skip to content

Migrate Segment Amazon Conversion connector to CAPI v2 open beta API #3550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bansrav wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Migrate Segment Amazon Conversion connector to CAPI v2 open beta API #3550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
787eb97
Migrate Segment Amazon Conversion connector to CAPI v2 open beta API
bansrav Jan 28, 2026
eb21451
Reverting the field names back to original for backward compatibility
bansrav Jan 29, 2026
fea4e7a
Reverting dataprocessing option field back to string array for backwa…
bansrav Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/destination-actions/src/destinations/amazon-conversions-api/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const destination: DestinationDefinition<Settings> = {
return {
headers: {
authorization: `Bearer ${auth?.accessToken}`,
'Amazon-Advertising-API-ClientID': process.env.ACTIONS_AMAZON_CONVERSIONS_API_CLIENT_ID || ''
'Amazon-Ads-ClientId': process.env.ACTIONS_AMAZON_CONVERSIONS_API_CLIENT_ID || ''
}
}
},
Expand Down
3 changes: 2 additions & 1 deletion ...-actions/src/destinations/amazon-conversions-api/trackConversion/__tests__/fields.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ describe('trackConversion fields', () => {
expect(fields.unitsSold?.type).toBe('integer')
expect(fields.clientDedupeId?.type).toBe('string')
expect(fields.dataProcessingOptions?.type).toBe('string')
expect(fields.dataProcessingOptions?.multiple).toBe(true)
expect(fields.consent?.type).toBe('object')
expect(fields.customAttributes?.type).toBe('object')
expect(fields.enable_batching.type).toBe('boolean')
Expand Down Expand Up @@ -74,13 +73,15 @@ describe('trackConversion fields', () => {
expect(fields.currencyCode?.depends_on).toBeDefined()
expect(fields.currencyCode?.depends_on?.conditions).toBeDefined()
expect(fields.currencyCode?.depends_on?.conditions?.[0]).toMatchObject({
fieldKey: 'eventType',
operator: 'is',
value: 'OFF_AMAZON_PURCHASES'
})

expect(fields.unitsSold?.depends_on).toBeDefined()
expect(fields.unitsSold?.depends_on?.conditions).toBeDefined()
expect(fields.unitsSold?.depends_on?.conditions?.[0]).toMatchObject({
fieldKey: 'eventType',
operator: 'is',
value: 'OFF_AMAZON_PURCHASES'
})
Expand Down
22 changes: 9 additions & 13 deletions ...n-actions/src/destinations/amazon-conversions-api/trackConversion/__tests__/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ describe('trackConversion', () => {
describe('perform', () => {
it('should send event data successfully', async () => {
nock(`${Region.NA}`)
.post('/events/v1')
.post('/adsApi/v1/create/events')
.reply(200, { success: true })

const responses = await testDestination.testAction('trackConversion', {
Expand All @@ -66,7 +66,7 @@ describe('trackConversion', () => {
it('should handle API errors', async () => {
// Mock an API error response
nock(`${Region.NA}`)
.post('/events/v1')
.post('/adsApi/v1/create/events')
.replyWithError('Invalid event data')

await expect(
Expand Down Expand Up @@ -95,7 +95,7 @@ describe('trackConversion', () => {
settings,
mapping: {
name: 'test_conversion',
// Missing eventType
// Missing conversionType
eventActionSource: 'website',
countryCode: 'US',
timestamp: '2023-01-01T12:00:00Z',
Expand Down Expand Up @@ -130,14 +130,10 @@ describe('trackConversion', () => {
it('should process a batch of events successfully', async () => {
// Mock a 207 multi-status response
nock(`${Region.NA}`)
.post('/events/v1')
.post('/adsApi/v1/create/events')
.reply(207, {
success: [
{ index: 1, message: 'Success' }
],
error: [
{ index: 2, httpStatusCode: '400', subErrors: [{ errorMessage: 'Invalid event' }] }
]
success: [{ index: 0, event: null }],
error: [{ index: 1, errors: [{ code: "BAD_REQUEST", message: 'Invalid data' }] }]
})

const responses = await testDestination.testBatchAction('trackConversion', {
Expand Down Expand Up @@ -169,9 +165,9 @@ describe('trackConversion', () => {
it('should handle validation errors for individual payloads', async () => {
// Mock the API request to send a partial success response
nock(`${Region.NA}`)
.post('/events/v1')
.post('/adsApi/v1/create/events')
.reply(207, {
success: [{ index: 1, message: 'Success' },{ index: 2, message: 'Success' }],
success: [{ index: 0, event: null }, { index: 1, event: null }],
error: []
})

Expand Down Expand Up @@ -221,7 +217,7 @@ describe('trackConversion', () => {

it('should handle API errors in batch mode', async () => {
nock(`${Region.NA}`)
.post('/events/v1')
.post('/adsApi/v1/create/events')
.reply(500, { error: 'Internal server error' })

// Spy on console.error to prevent error output during the test
Expand Down
Loading
Loading