Mixpanel Destination (#9)

* add json utilities and MixpanelDestination.kt

* fix from rebase

* remove adding token from main api

* fix tests

Author: prayansh

analytics-kotlin/src/main/java/com/segment/analytics/Analytics.kt

@@ -18,7 +18,12 @@ import sovran.kotlin.Store
 import sovran.kotlin.Subscriber
 
 class Analytics(internal val configuration: Configuration) : Subscriber {
-    internal val store: Store
+
+    private val _store: Store
+    internal val store: Store get() {
+        return _store
+    }
+
     internal val timeline: Timeline
     internal val analyticsScope: CoroutineScope
     internal val storage: Storage
@@ -33,7 +38,7 @@ class Analytics(internal val configuration: Configuration) : Subscriber {
         processingDispatcher = configuration.analyticsDispatcher
         ioDispatcher = configuration.ioDispatcher
         timeline = Timeline().also { it.analytics = this }
-        store = Store()
+        _store = Store()
 
         storage = configuration.storageProvider.getStorage(
             analytics = this,
@@ -359,10 +364,6 @@ class Analytics(internal val configuration: Configuration) : Subscriber {
     fun add(plugin: Plugin): Analytics {
         // could be done in background thread
         this.timeline.add(plugin)
-        store.currentState(System::class)?.settings?.let {
-            // if we have settings then update plugin with it
-            plugin.update(it)
-        }
         if (plugin is DestinationPlugin && plugin.name != "Segment.io") {
             analyticsScope.launch(ioDispatcher) {
                 store.dispatch(System.AddIntegrationAction(plugin.name), System::class)

analytics-kotlin/src/main/java/com/segment/analytics/platform/Timeline.kt

@@ -2,6 +2,7 @@ package com.segment.analytics.platform
 
 import com.segment.analytics.Analytics
 import com.segment.analytics.BaseEvent
+import com.segment.analytics.System
 
 // Platform abstraction for managing all plugins and their execution
 // Currently the execution follows
@@ -56,8 +57,12 @@ internal class Timeline {
 
     // Register a new plugin
     fun add(plugin: Plugin) {
-        plugins[plugin.type]?.add(plugin)
         plugin.setup(analytics)
+        plugins[plugin.type]?.add(plugin)
+        analytics.store.currentState(System::class)?.settings?.let {
+            // if we have settings then update plugin with it
+            plugin.update(it)
+        }
     }
 
     // Remove a registered plugin

analytics-kotlin/src/main/java/com/segment/analytics/utilities/JSON.kt

@@ -1,19 +1,88 @@
 package com.segment.analytics.utilities
 
-import kotlinx.serialization.json.JsonElement
-import kotlinx.serialization.json.JsonObject
-import kotlinx.serialization.json.JsonObjectBuilder
-import kotlinx.serialization.json.put
+import kotlinx.serialization.json.*
+import org.json.JSONArray
+import org.json.JSONObject
 
+// Utility function to put all values of `obj` into current builder
 fun JsonObjectBuilder.putAll(obj: JsonObject) {
     obj.forEach { (key, value) ->
         put(key, value)
     }
 }
 
+// Utility function to put "undefined" value in-stead of `null` when building JsonObject
 fun JsonObjectBuilder.putUndefinedIfNull(key: String, value: CharSequence?): JsonElement? =
     if (value.isNullOrEmpty()) {
         put(key, "undefined")
     } else {
         put(key, value.toString())
     }
+
+// Transform kotlinx.JsonArray to org.json.JSONArray
+fun List<JsonElement>.toJSONArray(): JSONArray {
+    val constructed = JSONArray()
+    for (item in this) {
+        when (item) {
+            is JsonPrimitive -> {
+                constructed.put(item.toContent())
+            }
+            is JsonObject -> {
+                constructed.put(item.toJSONObject())
+            }
+            is JsonArray -> {
+                constructed.put(item.toJSONArray())
+            }
+        }
+    }
+    return constructed
+}
+
+// Transform kotlinx.JsonArray to org.json.JSONArray
+fun Map<String, JsonElement>.toJSONObject(): JSONObject {
+    val constructed = JSONObject()
+    for ((k, v) in entries) {
+        when (v) {
+            is JsonPrimitive -> {
+                constructed.put(k, v.toContent())
+            }
+            is JsonObject -> {
+                constructed.put(k, v.toJSONObject())
+            }
+            is JsonArray -> {
+                constructed.put(k, v.toJSONArray())
+            }
+        }
+    }
+    return constructed
+}
+
+// Utility function to convert a jsonPrimitive to its appropriate kotlin type
+fun JsonPrimitive.toContent(): Any? {
+    this.booleanOrNull?.let {
+        return it
+    }
+    this.intOrNull?.let {
+        return it
+    }
+    this.longOrNull?.let {
+        return it
+    }
+    this.floatOrNull?.let {
+        return it
+    }
+    this.doubleOrNull?.let {
+        return it
+    }
+    return contentOrNull
+}
+
+// Utility function to retrieve a boolean value from a jsonObject
+fun JsonObject.getBoolean(key: String): Boolean? = this[key]?.jsonPrimitive?.boolean
+
+// Utility function to retrieve a string value from a jsonObject
+fun JsonObject.getString(key: String): String? = this[key]?.jsonPrimitive?.contentOrNull
+
+// Utility function to retrieve a string set (from jsonArray) from a jsonObject
+fun JsonObject.getStringSet(key: String): Set<String>? =
+    this[key]?.jsonArray?.map { it.jsonPrimitive.content }?.toSet()

analytics-kotlin/src/test/java/com/segment/analytics/main/utils/Mocks.kt

@@ -34,6 +34,8 @@ fun mockContext(): Context {
 
 fun mockAnalytics(): Analytics {
     val mock = mockk<Analytics>(relaxed = true)
+    val mockStore = Store()
+    every { mock.store } returns mockStore
     return mock
 }
 

samples/kotlin-android-app-destinations/build.gradle

@@ -37,6 +37,11 @@ android {
 }
 
 dependencies {
+
+    // Mixpanel
+    api 'com.mixpanel.android:mixpanel-android:5.8.7'
+
+
     implementation project(':analytics-kotlin')
 
     implementation 'androidx.multidex:multidex:2.0.1'

samples/kotlin-android-app-destinations/src/main/java/com/segment/analytics/destinations/MainApplication.kt

@@ -3,9 +3,8 @@ package com.segment.analytics.destinations
 import android.app.Application
 import com.segment.analytics.*
 import com.segment.analytics.destinations.plugins.AmplitudeSession
+import com.segment.analytics.destinations.plugins.MixpanelDestination
 import com.segment.analytics.destinations.plugins.WebhookPlugin
-import com.segment.analytics.platform.Plugin
-import com.segment.analytics.utilities.*
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.SupervisorJob
@@ -29,21 +28,9 @@ class MainApplication : Application() {
             this.flushAt = 1
             this.flushInterval = 0
         }
-        analytics.add(object : Plugin {
-            override val type: Plugin.Type = Plugin.Type.Enrichment
-            override val name: String = "Foo"
-            override lateinit var analytics: Analytics
-
-            override fun execute(event: BaseEvent): BaseEvent? {
-                event.enableIntegration("AppsFlyer")
-                event.disableIntegration("AppBoy")
-                event.putInContext("foo", "bar")
-                event.putInContextUnderKey("device", "android", true)
-                event.removeFromContext("locale")
-                return event
-            }
-
-        })
+
+        analytics.add(MixpanelDestination(applicationContext))
+
         // A random webhook url to view your events
         analytics.add(
             WebhookPlugin(