Skip to content

Commit 141b72b

Browse files
committed
wip
1 parent c1f8d8b commit 141b72b

File tree

3 files changed

+3
-49
lines changed

3 files changed

+3
-49
lines changed

packages/signals/signals-integration-tests/src/tests/custom-elements/custom-select.test.ts

Lines changed: 0 additions & 43 deletions
This file was deleted.

packages/signals/signals-integration-tests/src/tests/custom-elements/custom-textfield.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ test('Collecting signals whenever a user enters text input and focuses out', asy
1212
enableSignalsIngestion: true,
1313
})
1414
const fillAndConfirm = async (selector: string, text: string) => {
15-
await page.fill(selector, text)
16-
await page.keyboard.press('Enter')
15+
await page.getByTestId(selector).fill(text)
16+
await page.getByTestId(selector).press('Enter')
1717
}
1818
await Promise.all([
19-
fillAndConfirm('[data-testid="aria-text-field"]', 'John Doe'),
19+
fillAndConfirm('aria-text-field', 'John Doe'),
2020
waitForCondition(
2121
() => indexPage.signalsAPI.getEvents('interaction').length > 0,
2222
{ errorMessage: 'No interaction signals found' }

packages/signals/signals-integration-tests/src/tests/custom-elements/index-page.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,4 @@ export class IndexPage extends BasePage {
44
constructor() {
55
super(`/custom-elements/index.html`)
66
}
7-
async fillByTestId(testId: string, value: string) {
8-
return this.page.fill(`[data-testid="${testId}"]`, value)
9-
}
107
}

0 commit comments

Comments
 (0)