Skip to content

Commit 18d7a68

Browse files
committed
Update base signal
1 parent 63522a2 commit 18d7a68

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

packages/signals/signals-runtime/src/shared/shared-types.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
export interface BaseSignal {
22
type: string
3+
anonymousId: string
4+
timestamp: string
35
}
46

57
export type SignalOfType<

packages/signals/signals-runtime/src/test-helpers/mocks/mock-signal-types-web.ts

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { BaseSignal } from '../../shared/shared-types'
12
import {
23
InteractionSignal,
34
NavigationSignal,
@@ -8,6 +9,13 @@ import {
89
} from '../../web/web-signals-types'
910
// Mock data for testing
1011

12+
type DefaultProps = Pick<BaseSignal, 'anonymousId' | 'timestamp'>
13+
14+
const baseSignalProps: DefaultProps = {
15+
anonymousId: '123',
16+
timestamp: '2020-01-01T00:00:00.000Z',
17+
}
18+
1119
export const mockPageData: PageData = {
1220
url: 'https://www.segment.com/docs/connections/sources/catalog/libraries/website/javascript/',
1321
path: '/docs/connections/sources/catalog/libraries/website/javascript/',
@@ -29,7 +37,7 @@ export const mockInteractionSignal: InteractionSignal = {
2937
attributes: { id: 'button1', class: 'btn-primary' },
3038
},
3139
},
32-
metadata: { timestamp: Date.now() },
40+
...baseSignalProps,
3341
}
3442

3543
export const mockNavigationSignal: NavigationSignal = {
@@ -41,7 +49,7 @@ export const mockNavigationSignal: NavigationSignal = {
4149
hash: '#section1',
4250
prevUrl: 'https://example.com/home',
4351
},
44-
metadata: { timestamp: Date.now() },
52+
...baseSignalProps,
4553
}
4654

4755
export const mockInstrumentationSignal: InstrumentationSignal = {
@@ -50,7 +58,7 @@ export const mockInstrumentationSignal: InstrumentationSignal = {
5058
page: mockPageData,
5159
rawEvent: { type: 'customEvent', detail: 'example' },
5260
},
53-
metadata: { timestamp: Date.now() },
61+
...baseSignalProps,
5462
}
5563

5664
export const mockNetworkSignal: NetworkSignal = {
@@ -63,7 +71,7 @@ export const mockNetworkSignal: NetworkSignal = {
6371
method: 'GET',
6472
data: { key: 'value' },
6573
},
66-
metadata: { timestamp: Date.now() },
74+
...baseSignalProps,
6775
}
6876

6977
export const mockUserDefinedSignal: UserDefinedSignal = {
@@ -72,5 +80,5 @@ export const mockUserDefinedSignal: UserDefinedSignal = {
7280
page: mockPageData,
7381
customField: 'customValue',
7482
},
75-
metadata: { timestamp: Date.now() },
83+
...baseSignalProps,
7684
}

0 commit comments

Comments
 (0)