revert statusCode change

Author: silesky

packages/signals/signals-integration-tests/src/tests/signals-vanilla/network-signals-fetch.test.ts

@@ -69,7 +69,7 @@ test.describe('network signals - fetch', () => {
       action: 'response',
       url: 'http://localhost/test',
       data: { foo: 'test' },
-      statusCode: 200,
+      status: 200,
       ok: true,
     })
   })
@@ -179,7 +179,7 @@ test.describe('network signals - fetch', () => {
         action: 'response',
         url: 'http://localhost/test',
         data: { errorMsg: 'foo' },
-        statusCode: 400,
+        status: 400,
         ok: false,
       })
       expect(responses).toHaveLength(1)
@@ -218,7 +218,7 @@ test.describe('network signals - fetch', () => {
         action: 'response',
         url: 'http://localhost/test',
         data: 'foo',
-        statusCode: 400,
+        status: 400,
         ok: false,
       })
       expect(responses).toHaveLength(1)

packages/signals/signals/src/core/signal-generators/network-gen/__tests__/network-generator.test.ts

@@ -150,7 +150,7 @@ describe(NetworkGenerator, () => {
                 "data": "test",
               },
               "ok": true,
-              "statusCode": 200,
+              "status": 200,
               "url": "http://localhost/api",
             },
             "metadata": {
@@ -213,7 +213,7 @@ describe(NetworkGenerator, () => {
             "data": "test",
           },
           "ok": true,
-          "statusCode": 200,
+          "status": 200,
           "url": "http://localhost/test",
         },
         "metadata": {

packages/signals/signals/src/core/signal-generators/network-gen/helpers.ts

@@ -66,8 +66,7 @@ export function isPlainObject(obj: unknown): obj is Record<string, unknown> {
   )
 }
 
-export const isOk = (statusCode: number) =>
-  statusCode >= 200 && statusCode < 300
+export const isOk = (status: number) => status >= 200 && status < 300
 
 /**
  * Safely parse JSON, if it fails, return the original text.

packages/signals/signals/src/core/signal-generators/network-gen/index.ts

@@ -100,7 +100,7 @@ export class NetworkGenerator implements SignalGenerator {
             url,
             data: data,
             ok: rs.ok,
-            statusCode: rs.statusCode,
+            status: rs.status,
           },
           createMetadata()
         )

packages/signals/signals/src/core/signal-generators/network-gen/network-interceptor.ts

@@ -21,7 +21,7 @@ export interface NetworkInterceptorRequest {
 
 export interface NetworkInterceptorResponse {
   url: string
-  statusCode: number
+  status: number
   ok: boolean
   statusText: string
   headers: Headers
@@ -58,7 +58,7 @@ const createInterceptorResponse = ({
   body,
   headers,
   initiator,
-  statusCode,
+  status,
   statusText,
   url,
   responseType,
@@ -67,7 +67,7 @@ const createInterceptorResponse = ({
   body: () => Promise<JSONValue>
   headers: Headers
   initiator: 'fetch' | 'xhr'
-  statusCode: number
+  status: number
   statusText: string
   url: string
   responseType: XMLHttpRequestResponseType | undefined
@@ -76,8 +76,8 @@ const createInterceptorResponse = ({
   body,
   headers,
   initiator,
-  ok: isOk(statusCode),
-  statusCode,
+  ok: isOk(status),
+  status,
   statusText,
   url,
   responseType,
@@ -161,7 +161,7 @@ export class NetworkInterceptor {
             body: lazyBody,
             headers: response.headers,
             initiator: 'fetch',
-            statusCode: response.status,
+            status: response.status,
             statusText: response.statusText,
             url: response.url,
             responseType: undefined,
@@ -240,7 +240,7 @@ export class NetworkInterceptor {
             try {
               onResponse(
                 createInterceptorResponse({
-                  statusCode: this.status,
+                  status: this.status,
                   responseType: this.responseType,
                   statusText: this.statusText,
                   url: this.responseURL,

packages/signals/signals/src/types/__tests__/create-network-signal.test.ts

@@ -60,7 +60,7 @@ describe(createNetworkSignal, () => {
       action: 'response',
       url: 'http://example.com',
       ok: true,
-      statusCode: 200,
+      status: 200,
       data: { key: 'value' },
     }
 
@@ -74,7 +74,7 @@ describe(createNetworkSignal, () => {
             "key": "value",
           },
           "ok": true,
-          "statusCode": 200,
+          "status": 200,
           "url": "http://example.com",
         },
         "metadata": {