Skip to content

Commit 1de5c29

Browse files
committed
wip
1 parent b5763cc commit 1de5c29

File tree

3 files changed

+11
-18
lines changed

3 files changed

+11
-18
lines changed

.changeset/little-chefs-hunt.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
'@segment/analytics-signals': minor
3+
---
4+
- Fix runtime errors for submit
5+
- Add better form submit data
6+
- Loosen content-type to parse text/plain
7+
- Tweak disallow list
8+
- Add labels

packages/signals/signals/src/core/signal-generators/network-gen/__tests__/network-generator.test.ts

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -142,24 +142,6 @@ describe(NetworkGenerator, () => {
142142
await sleep(100)
143143
expect(mockEmitter.emit.mock.calls).toMatchInlineSnapshot(`
144144
[
145-
[
146-
{
147-
"data": {
148-
"action": "request",
149-
"contentType": "text/html",
150-
"data": "hello world",
151-
"method": "GET",
152-
"url": "http://localhost/api",
153-
},
154-
"metadata": {
155-
"filters": {
156-
"allowed": [],
157-
"disallowed": [],
158-
},
159-
},
160-
"type": "network",
161-
},
162-
],
163145
[
164146
{
165147
"data": {

packages/signals/signals/src/core/signals/signals.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,9 @@ export class Signals implements ISignals {
9090
disallowListURLs: [
9191
analyticsService.instance.settings.apiHost,
9292
analyticsService.instance.settings.cdnURL,
93+
'api.segment.io',
94+
'signals.segment.io',
95+
'cdn.segment.com',
9396
],
9497
sampleRate:
9598
analyticsService.instance.settings.cdnSettings

0 commit comments

Comments
 (0)