Fix filtering of non-consented device mode integrations (#1328)

Author: chenxzhang

.changeset/nine-dolphins-talk.md

@@ -0,0 +1,5 @@
+---
+'@segment/analytics-consent-tools': patch
+---
+
+Fix filtering of non-consented integrations

packages/consent/consent-tools/src/domain/__tests__/create-wrapper.test.ts

@@ -424,6 +424,68 @@ describe(createWrapper, () => {
         updatedCDNSettings
       )
     })
+
+    it('should filter ALL non-consented remote plugins when multiple integrations need to be blocked', async () => {
+      const mockCdnSettings = cdnSettingsBuilder
+        .addActionDestinationSettings(
+          {
+            creationName: 'GoogleAnalytics',
+            consentSettings: {
+              categories: ['Analytics'],
+            },
+          },
+          {
+            creationName: 'FacebookPixel',
+            consentSettings: {
+              categories: ['Advertising'],
+            },
+          },
+          {
+            creationName: 'TikTokPixel',
+            consentSettings: {
+              categories: ['Advertising'],
+            },
+          },
+          {
+            creationName: 'PinterestTag',
+            consentSettings: {
+              categories: ['Advertising'],
+            },
+          }
+        )
+        .build()
+
+      wrapTestAnalytics({
+        getCategories: () => ({ Analytics: true }), // Only Analytics consented, NOT Advertising
+      })
+
+      await analytics.load({
+        ...DEFAULT_LOAD_SETTINGS,
+        cdnSettings: mockCdnSettings,
+      })
+
+      expect(analyticsLoadSpy).toBeCalled()
+      const { updatedCDNSettings } = getAnalyticsLoadLastCall()
+
+      expect(typeof updatedCDNSettings.remotePlugins).toBe('object')
+
+      // Only GoogleAnalytics should be present - all Advertising integrations should be filtered
+      assertIntegrationsContainOnly(
+        ['GoogleAnalytics'],
+        mockCdnSettings,
+        updatedCDNSettings
+      )
+
+      const remotePluginNames = updatedCDNSettings.remotePlugins?.map(
+        (p) => p.creationName
+      )
+
+      // Explicitly verify that all Advertising integrations are blocked
+      expect(remotePluginNames).not.toContain('FacebookPixel')
+      expect(remotePluginNames).not.toContain('TikTokPixel')
+      expect(remotePluginNames).not.toContain('PinterestTag')
+      expect(remotePluginNames).toContain('GoogleAnalytics')
+    })
   })
 
   describe('shouldDisableSegment', () => {

packages/consent/consent-tools/src/domain/blocking-helpers.ts

@@ -101,7 +101,7 @@ export const filterDeviceModeDestinationsForOptIn = (
   for (const creationName in integrations) {
     if (!_shouldEnableIntegrationHelper(creationName)) {
       logger.debug(`Disabled (opt-in): ${creationName}`)
-      cdnSettingsCopy.remotePlugins = remotePlugins?.filter(
+      cdnSettingsCopy.remotePlugins = cdnSettingsCopy.remotePlugins?.filter(
         (p) => p.creationName !== creationName
       )
       // remove disabled classic destinations and locally-installed action destinations