Skip to content

Commit 2870f36

Browse files
committed
wip
1 parent cae6681 commit 2870f36

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

packages/signals/signals-integration-tests/src/helpers/base-page-object.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export class BasePage {
6464
await this.page.goto(url, { waitUntil: 'domcontentloaded' })
6565
if (!options.skipSignalsPluginInit) {
6666
void this.invokeAnalyticsLoad({
67-
sandboxStrategy: envConfig.SANDBOX_STRATEGY ?? 'iframe',
67+
sandboxStrategy: envConfig.SANDBOX_STRATEGY,
6868
flushInterval: 500,
6969
...signalSettings,
7070
})

packages/signals/signals-integration-tests/src/helpers/env-config.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@ import { SignalsSettingsConfig } from '@segment/analytics-signals/dist/types/cor
22

33
// This is for testing with the global sandbox strategy with an npm script, that executes processSignal in the global scope
44
// If we change this to be the default, this can be rejiggered
5-
const SANDBOX_STRATEGY = process.env.SANDBOX_STRATEGY as
6-
| SignalsSettingsConfig['sandboxStrategy']
7-
| undefined
5+
const SANDBOX_STRATEGY = (process.env.SANDBOX_STRATEGY ??
6+
'iframe') as SignalsSettingsConfig['sandboxStrategy']
87

98
export const envConfig = {
109
SANDBOX_STRATEGY,

0 commit comments

Comments
 (0)