wip

Author: silesky

packages/signals/signals/src/core/buffer/__tests__/buffer.test.ts

@@ -86,3 +86,49 @@ describe(getSignalBuffer, () => {
     await expect(buffer.getAll()).resolves.toHaveLength(0)
   })
 })
+
+describe('SignalStoreSessionStorage', () => {
+  let buffer: SignalBuffer
+
+  beforeEach(async () => {
+    sessionStorage.clear()
+    buffer = getSignalBuffer({
+      maxBufferSize: 10,
+      storageType: 'session',
+    })
+    await buffer.clear()
+  })
+
+  it('should instantiate without throwing an error', () => {
+    expect(buffer).toBeTruthy()
+  })
+
+  it('should add and clear', async () => {
+    const mockSignal = createInteractionSignal({
+      eventType: 'submit',
+      target: {},
+    })
+    await buffer.add(mockSignal)
+    await expect(buffer.getAll()).resolves.toEqual([mockSignal])
+    await buffer.clear()
+    await expect(buffer.getAll()).resolves.toHaveLength(0)
+  })
+
+  it('should delete older signals when maxBufferSize is exceeded', async () => {
+    const signals = range(15).map((_, idx) =>
+      createInteractionSignal({
+        idx: idx,
+        eventType: 'change',
+        target: {},
+      })
+    )
+
+    for (const signal of signals) {
+      await buffer.add(signal)
+    }
+
+    const storedSignals = await buffer.getAll()
+    expect(storedSignals).toHaveLength(10)
+    expect(storedSignals).toEqual(signals.slice(-10).reverse())
+  })
+})

packages/signals/signals/src/core/buffer/index.ts

@@ -141,25 +141,22 @@ export class SignalStoreSessionStorage implements SignalPersistentStorage {
   }
 
   add(signal: Signal): void {
-    const signals = this.getAllSync()
-    signals.push(signal)
+    const signals = this.getAll()
+    signals.unshift(signal)
     if (signals.length > this.maxBufferSize) {
-      signals.splice(0, signals.length - this.maxBufferSize)
+      // delete the last one
+      signals.splice(-1)
     }
     sessionStorage.setItem(this.storageKey, JSON.stringify(signals))
   }
 
-  getAll(): Promise<Signal[]> {
-    return Promise.resolve(this.getAllSync())
+  clear(): void {
+    sessionStorage.removeItem(this.storageKey)
   }
 
-  private getAllSync(): Signal[] {
+  getAll(): Signal[] {
     const signals = sessionStorage.getItem(this.storageKey)
-    return signals ? JSON.parse(signals).reverse() : []
-  }
-
-  clear(): void {
-    sessionStorage.removeItem(this.storageKey)
+    return signals ? JSON.parse(signals) : []
   }
 }