wip

Author: silesky

packages/signals/signals-runtime/editor/mobile-editor.d.ts

@@ -57,6 +57,7 @@ interface NetworkData {
 }
 interface NetworkSignal extends RawSignal<"network"> {
 	data: NetworkData;
+	[key: string]: unknown;
 }
 interface LocalData {
 	action: LocalDataAction;

packages/signals/signals/src/core/processor/__tests__/signals-runtime.test.ts renamed to packages/signals/signals-runtime/src/__tests__/signals-runtime.test.ts

@@ -2,24 +2,27 @@ import {
   InstrumentationSignal,
   InteractionSignal,
   SignalsRuntime,
-} from '../../../types'
+  Signal,
+} from '../index'
 import {
-  createInstrumentationSignal,
-  createInteractionSignal,
-} from '../../../types/factories'
-import { createSignalsRuntime } from '../signals-runtime'
+  mockInstrumentationSignal,
+  mockInteractionSignal,
+} from '../test-helpers/mocks/mock-signal-types-web'
 
-describe('SignalsRuntime', () => {
-  let signalsRuntime: SignalsRuntime
+describe(SignalsRuntime, () => {
+  let signalsRuntime: SignalsRuntime<Signal>
   let signal1: InstrumentationSignal
   let signal2: InteractionSignal
   let signal3: InteractionSignal
 
   beforeEach(() => {
-    signal1 = createInstrumentationSignal({ type: 'track' })
-    signal2 = createInteractionSignal({ eventType: 'submit', submitter: {} })
-    signal3 = createInteractionSignal({ eventType: 'change', target: {} })
-    signalsRuntime = createSignalsRuntime([signal1, signal2, signal3])
+    signal1 = mockInstrumentationSignal
+    signal2 = mockInteractionSignal
+    signal3 = {
+      ...mockInteractionSignal,
+      data: { eventType: 'change', target: {} },
+    }
+    signalsRuntime = new SignalsRuntime<Signal>([signal1, signal2, signal3])
   })
 
   describe('find', () => {
@@ -47,16 +50,4 @@ describe('SignalsRuntime', () => {
       expect(result).toEqual(signal2)
     })
   })
-
-  describe('filter', () => {
-    it('should filter signals based on the provided function', () => {
-      const result = signalsRuntime.filter(signal1, 'interaction')
-      expect(result).toEqual([signal2, signal3])
-    })
-
-    it('should return empty array if there are no following signals that match the query', () => {
-      const result = signalsRuntime.filter(signal1, 'instrumentation')
-      expect(result).toEqual([])
-    })
-  })
 })

packages/signals/signals-runtime/src/test-helpers/mocks/mock-signal-types-web.ts

@@ -0,0 +1,54 @@
+import {
+  InteractionSignal,
+  NavigationSignal,
+  InstrumentationSignal,
+  UserDefinedSignal,
+  NetworkSignal,
+} from '../../web/web-signals-types'
+// Mock data for testing
+export const mockInteractionSignal: InteractionSignal = {
+  type: 'interaction',
+  data: {
+    eventType: 'click',
+    target: { id: 'button1', className: 'btn-primary' },
+  },
+  metadata: { timestamp: Date.now() },
+}
+
+export const mockNavigationSignal: NavigationSignal = {
+  type: 'navigation',
+  data: {
+    action: 'urlChange',
+    url: 'https://example.com',
+    hash: '#section1',
+    prevUrl: 'https://example.com/home',
+  },
+  metadata: { timestamp: Date.now() },
+}
+
+export const mockInstrumentationSignal: InstrumentationSignal = {
+  type: 'instrumentation',
+  data: {
+    rawEvent: { type: 'customEvent', detail: 'example' },
+  },
+  metadata: { timestamp: Date.now() },
+}
+
+export const mockNetworkSignal: NetworkSignal = {
+  type: 'network',
+  data: {
+    action: 'request',
+    url: 'https://api.example.com/data',
+    method: 'GET',
+    data: { key: 'value' },
+  },
+  metadata: { timestamp: Date.now() },
+}
+
+export const mockUserDefinedSignal: UserDefinedSignal = {
+  type: 'userDefined',
+  data: {
+    customField: 'customValue',
+  },
+  metadata: { timestamp: Date.now() },
+}

packages/signals/signals/src/core/client/__tests__/redact.test.ts

@@ -1,9 +1,5 @@
-import {
-  createInstrumentationSignal,
-  createInteractionSignal,
-  createNetworkSignal,
-  NetworkSignalMetadata,
-} from '../../../types'
+import { NetworkSignalMetadata } from '../../../types'
+import * as factories from '../../../types/factories'
 import { redactJsonValues, redactSignalData } from '../redact'
 
 describe(redactJsonValues, () => {
@@ -69,7 +65,7 @@ describe(redactSignalData, () => {
     },
   }
   it('should return the signal as is if the type is "instrumentation"', () => {
-    const signal = createInstrumentationSignal({
+    const signal = factories.createInstrumentationSignal({
       foo: 123,
     } as any)
     expect(redactSignalData(signal)).toEqual(signal)
@@ -81,19 +77,19 @@ describe(redactSignalData, () => {
   })
 
   it('should redact the value in the "target" property if the type is "interaction"', () => {
-    const signal = createInteractionSignal({
+    const signal = factories.createInteractionSignal({
       eventType: 'change',
       target: { value: 'secret' },
     })
-    const expected = createInteractionSignal({
+    const expected = factories.createInteractionSignal({
       eventType: 'change',
       target: { value: 'XXX' },
     })
     expect(redactSignalData(signal)).toEqual(expected)
   })
 
   it('should redact the values in the "data" property if the type is "network"', () => {
-    const signal = createNetworkSignal(
+    const signal = factories.createNetworkSignal(
       {
         action: 'request',
         method: 'post',
@@ -102,7 +98,7 @@ describe(redactSignalData, () => {
       },
       metadataFixture
     )
-    const expected = createNetworkSignal(
+    const expected = factories.createNetworkSignal(
       {
         action: 'request',
         method: 'post',
@@ -115,7 +111,7 @@ describe(redactSignalData, () => {
   })
 
   it('should not mutate the original signal object', () => {
-    const originalSignal = createInteractionSignal({
+    const originalSignal = factories.createInteractionSignal({
       eventType: 'click',
       target: { value: 'sensitiveData' },
     })