fix tests

Author: silesky

packages/signals/signals/src/core/processor/__tests__/sandbox-settings.test.ts

@@ -19,31 +19,30 @@ describe(IframeSandboxSettings, () => {
     expect(await sandboxSettings.processSignal).toEqual(edgeFnResponseBody)
   })
 
-  test('normalizes edgeFnDownloadURL when functionHost is provided', async () => {
-    const settings = {
+  test('should call edgeFnDownloadURL', async () => {
+    const settings: IframeSandboxSettingsConfig = {
       ...baseSettings,
       processSignal: undefined,
-      functionHost: 'newHost.com',
-      edgeFnDownloadURL: 'https://original.com/download',
+      edgeFnDownloadURL: 'https://foo.com/download',
     }
     new IframeSandboxSettings(settings)
     expect(baseSettings.edgeFnFetchClient).toHaveBeenCalledWith(
-      'https://newHost.com/download'
+      'https://foo.com/download'
     )
   })
 
   test('creates default processSignal when parameters are missing', async () => {
     const consoleWarnSpy = jest
       .spyOn(console, 'warn')
       .mockImplementation(() => {})
-    const settings = {
+    const settings: IframeSandboxSettingsConfig = {
       ...baseSettings,
       processSignal: undefined,
       edgeFnDownloadURL: undefined,
     }
     const sandboxSettings = new IframeSandboxSettings(settings)
-    expect(await sandboxSettings.processSignal).toEqual(
-      'globalThis.processSignal = function processSignal() {}'
+    expect(await sandboxSettings.processSignal).toMatchInlineSnapshot(
+      `"globalThis.processSignal = function() {}"`
     )
     expect(baseSettings.edgeFnFetchClient).not.toHaveBeenCalled()
     expect(consoleWarnSpy).toHaveBeenCalledWith(

packages/signals/signals/src/core/processor/sandbox.ts

@@ -180,6 +180,11 @@ export type IframeSandboxSettingsConfig = Pick<
   'processSignal' | 'edgeFnFetchClient' | 'edgeFnDownloadURL'
 >
 
+const consoleWarnProcessSignal = () =>
+  console.warn(
+    'processSignal is not defined - have you set up auto-instrumentation on app.segment.com?'
+  )
+
 export class IframeSandboxSettings {
   /**
    * Should look like:
@@ -193,11 +198,21 @@ export class IframeSandboxSettings {
   constructor(settings: IframeSandboxSettingsConfig) {
     const fetch = settings.edgeFnFetchClient ?? globalThis.fetch
 
-    const processSignalNormalized = settings.processSignal
-      ? Promise.resolve(settings.processSignal).then(
-          (str) => `globalThis.processSignal = ${str}`
-        )
-      : fetch(settings.edgeFnDownloadURL!).then((res) => res.text())
+    let processSignalNormalized = Promise.resolve(
+      `globalThis.processSignal = function() {}`
+    )
+
+    if (settings.processSignal) {
+      processSignalNormalized = Promise.resolve(settings.processSignal).then(
+        (str) => `globalThis.processSignal = ${str}`
+      )
+    } else if (settings.edgeFnDownloadURL) {
+      processSignalNormalized = fetch(settings.edgeFnDownloadURL!).then((res) =>
+        res.text()
+      )
+    } else {
+      consoleWarnProcessSignal()
+    }
 
     this.processSignal = processSignalNormalized
   }
@@ -258,7 +273,7 @@ const processWithGlobalScopeExecutionEnv = (
   const processSignal: ProcessSignal = g['processSignal']
 
   if (typeof processSignal == 'undefined') {
-    console.warn('no processSignal function is defined in the global scope')
+    consoleWarnProcessSignal()
     return undefined
   }