Skip to content

Commit 3290eea

Browse files
committed
wip
1 parent 41c17a0 commit 3290eea

File tree

2 files changed

+13
-28
lines changed

2 files changed

+13
-28
lines changed

packages/signals/signals/src/core/processor/sandbox.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
11
import { logger } from '../../lib/logger'
22
import { createWorkerBox, WorkerBoxAPI } from '../../lib/workerbox'
33
import { resolvers } from './arg-resolvers'
4-
import { AnalyticsRuntimePublicApi, AnalyticsEnums } from '../../types'
4+
import { AnalyticsRuntimePublicApi } from '../../types'
55
import { replaceBaseUrl } from '../../lib/replace-base-url'
6-
import { SignalsRuntime, Signal } from '@segment/analytics-signals-runtime'
6+
import {
7+
SignalsRuntime,
8+
Signal,
9+
WebConstants,
10+
} from '@segment/analytics-signals-runtime'
711

812
export type MethodName =
913
| 'page'
@@ -207,7 +211,7 @@ export class Sandbox {
207211
const analytics = new AnalyticsRuntime()
208212
const scope = {
209213
analytics,
210-
...AnalyticsEnums,
214+
...WebConstants,
211215
}
212216
logger.debug('processing signal', { signal, scope, signals })
213217
const code = [
Lines changed: 6 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
import { ISignalsRuntime, Signal } from '@segment/analytics-signals-runtime'
1+
import {
2+
ISignalsRuntime,
3+
Signal,
4+
WebConstants,
5+
} from '@segment/analytics-signals-runtime'
26

37
/**
48
* Types for the signals runtime
@@ -15,31 +19,8 @@ export interface AnalyticsRuntimePublicApi {
1519
export type ProcessSignalScope = {
1620
analytics: AnalyticsRuntimePublicApi
1721
signals: ISignalsRuntime<Signal>
18-
} & typeof AnalyticsEnums
22+
} & typeof WebConstants
1923

2024
export interface ProcessSignal {
2125
(signal: Signal, ctx: ProcessSignalScope): void
2226
}
23-
24-
export const AnalyticsEnums = {
25-
SignalType: Object.freeze({
26-
Interaction: 'interaction',
27-
Navigation: 'navigation',
28-
Network: 'network',
29-
LocalData: 'localData',
30-
Instrumentation: 'instrumentation',
31-
UserDefined: 'userDefined',
32-
}),
33-
EventType: Object.freeze({
34-
Track: 'track',
35-
Page: 'page',
36-
Screen: 'screen',
37-
Identify: 'identify',
38-
Group: 'group',
39-
Alias: 'alias',
40-
}),
41-
NavigationAction: Object.freeze({
42-
URLChange: 'urlChange',
43-
PageLoad: 'pageLoad',
44-
}),
45-
}

0 commit comments

Comments
 (0)