wip

silesky · silesky · commit 49432fdc99ed · 2025-03-10T14:44:21.000-05:00
diff --git a/packages/signals/signals-runtime/build-signals-runtime-global.js b/packages/signals/signals-runtime/build-signals-runtime-global.js
@@ -64,9 +64,9 @@ const buildRuntimeAsString = async (platform) => {
   console.log(`wrote: ${generatedTsFile}`)
 }
 
-// while esbuild supports target: es5 natively, it chokes with errors like]
-// ✘ [ERROR] Transforming const to the configured target environment ("es5") is not supported yet
 const compileToEs5WithBabel = (outFile) => {
+  // While esbuild supports target: es5 natively, we use babel because esbuild chokes with errors. e.g.:
+  // ✘ [ERROR] Transforming const to the configured target environment ("es5") is not supported yet
   return execSync(
     `npx babel ${outFile} --out-file ${outFile} --config-file ./babel.config.js`
   )

Original file line number	Diff line number	Diff line change
`@@ -64,9 +64,9 @@ const buildRuntimeAsString = async (platform) => {`
`64`	`64`	console.log(`wrote: ${generatedTsFile}`)
`65`	`65`	`}`
`66`	`66`
`67`		`-// while esbuild supports target: es5 natively, it chokes with errors like]`
`68`		`-// ✘ [ERROR] Transforming const to the configured target environment ("es5") is not supported yet`
`69`	`67`	`const compileToEs5WithBabel = (outFile) => {`
	`68`	`+ // While esbuild supports target: es5 natively, we use babel because esbuild chokes with errors. e.g.:`
	`69`	`+ // ✘ [ERROR] Transforming const to the configured target environment ("es5") is not supported yet`
`70`	`70`	`return execSync(`
`71`	`71`	`npx babel ${outFile} --out-file ${outFile} --config-file ./babel.config.js`
`72`	`72`	`)`