update sandbox

silesky · silesky · commit 4ad4d825ca56 · 2025-04-29T18:33:01.000-05:00
diff --git a/packages/signals/signals/src/core/processor/sandbox.ts b/packages/signals/signals/src/core/processor/sandbox.ts
@@ -292,6 +292,7 @@ const processWithGlobalScopeExecutionEnv = (
       'Invariant: analytics variable was not properly restored on the previous execution. This indicates a concurrency bug'
     )
   }
+  const originalSignals = g.signals
 
   try {
     g['analytics'] = analytics
@@ -309,10 +310,9 @@ const processWithGlobalScopeExecutionEnv = (
   } finally {
     // restore globals
     g['analytics'] = originalAnalytics
+    g['signals'] = originalSignals
   }
 
-  // this seems like it could potentially cause bugs in async environment
-  g.analytics = originalAnalytics
   return analytics.getCalls()
 }
 

Original file line number	Diff line number	Diff line change
`@@ -292,6 +292,7 @@ const processWithGlobalScopeExecutionEnv = (`
`292`	`292`	`'Invariant: analytics variable was not properly restored on the previous execution. This indicates a concurrency bug'`
`293`	`293`	`)`
`294`	`294`	`}`
	`295`	`+ const originalSignals = g.signals`
`295`	`296`
`296`	`297`	`try {`
`297`	`298`	`g['analytics'] = analytics`
`@@ -309,10 +310,9 @@ const processWithGlobalScopeExecutionEnv = (`
`309`	`310`	`} finally {`
`310`	`311`	`// restore globals`
`311`	`312`	`g['analytics'] = originalAnalytics`
	`313`	`+ g['signals'] = originalSignals`
`312`	`314`	`}`
`313`	`315`
`314`		`- // this seems like it could potentially cause bugs in async environment`
`315`		`- g.analytics = originalAnalytics`
`316`	`316`	`return analytics.getCalls()`
`317`	`317`	`}`
`318`	`318`