tweak node logic (#814)

Author: silesky

packages/node/src/lib/__tests__/env.test.ts

@@ -1,8 +1,9 @@
 import { detectRuntime, RuntimeEnv } from '../env'
 
-const ogProcess = { ...process.env }
+const ogProcessEnv = { ...process.env }
+
 afterEach(() => {
-  process.env = ogProcess
+  process.env = ogProcessEnv
   // @ts-ignore
   delete globalThis.window
 
@@ -16,17 +17,10 @@ afterEach(() => {
   delete globalThis.window
 })
 describe(detectRuntime, () => {
-  it('should return web worker if correct env', () => {
-    // @ts-ignore
-    // eslint-disable-next-line
-    delete process.env
-    // @ts-ignore
-    globalThis.WorkerGlobalScope = {}
-    // @ts-ignore
-    globalThis.importScripts = () => {}
-
-    expect(detectRuntime()).toEqual<RuntimeEnv>('web-worker')
+  it('should return node since these tests run in node', () => {
+    expect(detectRuntime()).toEqual<RuntimeEnv>('node')
   })
+
   it('should return browser if correct env', () => {
     // @ts-ignore
     // eslint-disable-next-line
@@ -35,12 +29,6 @@ describe(detectRuntime, () => {
     globalThis.window = {}
     expect(detectRuntime()).toEqual<RuntimeEnv>('browser')
   })
-  it('should return node if correct env', () => {
-    // @ts-ignore
-    // eslint-disable-next-line
-    process = { env: {} }
-    expect(detectRuntime()).toEqual<RuntimeEnv>('node')
-  })
 
   it('should return cloudflare worker if correct env', () => {
     // @ts-ignore

packages/node/src/lib/env.ts

@@ -7,7 +7,13 @@ export type RuntimeEnv =
   | 'unknown'
 
 export const detectRuntime = (): RuntimeEnv => {
-  if (typeof process === 'object' && process && process.env) {
+  if (
+    typeof process === 'object' &&
+    process &&
+    typeof process.env === 'object' &&
+    process.env &&
+    typeof process.version === 'string'
+  ) {
     return 'node'
   }
 

packages/node/src/plugins/segmentio/index.ts

@@ -10,10 +10,7 @@ function normalizeEvent(ctx: Context) {
   ctx.updateEvent('context.library.version', version)
   const runtime = detectRuntime()
   if (runtime === 'node') {
-    // extra guard here was important for vercel edge.
-    if (typeof process.versions === 'object') {
-      ctx.updateEvent('_metadata.nodeVersion', process.versions.node)
-    }
+    ctx.updateEvent('_metadata.nodeVersion', process.version)
   }
   ctx.updateEvent('_metadata.jsRuntime', runtime)
 }