remove unneccessary tests, make retryQueue less misleading

Author: silesky

packages/browser/src/plugins/segmentio/__tests__/retries.test.ts

@@ -5,20 +5,11 @@ jest.mock('unfetch', () => {
 
 import { segmentio, SegmentioSettings } from '..'
 import { Analytics } from '../../../core/analytics'
-// @ts-ignore isOffline mocked dependency is accused as unused
-import { isOffline } from '../../../core/connection'
 import { Plugin } from '../../../core/plugin'
 import { envEnrichment } from '../../env-enrichment'
-import { scheduleFlush } from '../schedule-flush'
-import * as PPQ from '../../../lib/priority-queue/persisted'
 import * as PQ from '../../../lib/priority-queue'
-import { Context } from '../../../core/context'
 import { createError, createSuccess } from '../../../test-helpers/factories'
 
-//jest.mock('../schedule-flush')
-
-type QueueType = 'priority' | 'persisted'
-
 describe('Segment.io retries 500s and 429', () => {
   let options: SegmentioSettings
   let analytics: Analytics
@@ -29,20 +20,14 @@ describe('Segment.io retries 500s and 429', () => {
     jest.restoreAllMocks()
 
     options = { apiKey: 'foo' }
-    analytics = new Analytics(
-      { writeKey: options.apiKey },
-      {
-        retryQueue: true,
-      }
-    )
+    analytics = new Analytics({ writeKey: options.apiKey })
     segment = await segmentio(analytics, options, {})
     await analytics.register(segment, envEnrichment)
   })
 
   test('retries on 500', async () => {
     jest.useFakeTimers({ advanceTimers: true })
     fetch.mockReturnValue(createError({ status: 500 }))
-    // .mockReturnValue(createSuccess({}))
     const ctx = await analytics.track('event')
     jest.runAllTimers()
 
@@ -88,12 +73,7 @@ describe('Batches retry 500s and 429', () => {
         config: { size: 3, timeout: 1, maxRetries: 2 },
       },
     }
-    analytics = new Analytics(
-      { writeKey: options.apiKey },
-      {
-        retryQueue: true,
-      }
-    )
+    analytics = new Analytics({ writeKey: options.apiKey })
     segment = await segmentio(analytics, options, {})
     await analytics.register(segment, envEnrichment)
   })
@@ -142,73 +122,3 @@ describe('Batches retry 500s and 429', () => {
     expect(fetch.mock.lastCall[1].body).toContain('"retryCount":2')
   })
 })
-
-describe('Segment.io retries', () => {
-  let options: SegmentioSettings
-  let analytics: Analytics
-  let segment: Plugin
-  let queue: (PPQ.PersistedPriorityQueue | PQ.PriorityQueue<Context>) & {
-    __type?: QueueType
-  }
-  ;[false, true].forEach((persistenceIsDisabled) => {
-    describe(`disableClientPersistence: ${persistenceIsDisabled}`, () => {
-      beforeEach(async () => {
-        jest.useRealTimers()
-        jest.resetAllMocks()
-        jest.restoreAllMocks()
-
-        // @ts-expect-error reassign import
-        isOffline = jest.fn().mockImplementation(() => true)
-        // @ts-expect-error reassign import
-        scheduleFlush = jest.fn().mockImplementation(() => {})
-
-        options = { apiKey: 'foo' }
-        analytics = new Analytics(
-          { writeKey: options.apiKey },
-          {
-            retryQueue: true,
-            disableClientPersistence: persistenceIsDisabled,
-          }
-        )
-
-        if (persistenceIsDisabled) {
-          queue = new PQ.PriorityQueue(3, [])
-          queue['__type'] = 'priority'
-          Object.defineProperty(PQ, 'PriorityQueue', {
-            writable: true,
-            value: jest.fn().mockImplementation(() => queue),
-          })
-        } else {
-          queue = new PPQ.PersistedPriorityQueue(
-            3,
-            `${options.apiKey}:test-Segment.io`
-          )
-          queue['__type'] = 'persisted'
-          Object.defineProperty(PPQ, 'PersistedPriorityQueue', {
-            writable: true,
-            value: jest.fn().mockImplementation(() => queue),
-          })
-        }
-
-        segment = await segmentio(analytics, options, {})
-        await analytics.register(segment, envEnrichment)
-      })
-
-      test(`add events to the queue`, async () => {
-        jest.spyOn(queue, 'push')
-
-        const ctx = await analytics.track('event')
-
-        expect(scheduleFlush).toHaveBeenCalled()
-        /* eslint-disable  @typescript-eslint/unbound-method */
-        expect(queue.push).toHaveBeenCalled()
-        expect(queue.length).toBe(1)
-        expect(ctx.attempts).toBe(1)
-        expect(isOffline).toHaveBeenCalledTimes(2)
-        expect(queue.__type).toBe<QueueType>(
-          persistenceIsDisabled ? 'priority' : 'persisted'
-        )
-      })
-    })
-  })
-})