refactor node tests (#681)

Author: silesky

packages/node/src/__tests__/graceful-shutdown-integration.test.ts

@@ -18,7 +18,6 @@ const testPlugin: CorePlugin = {
 describe('Ability for users to exit without losing events', () => {
   let ajs!: Analytics
   beforeEach(async () => {
-    jest.resetAllMocks()
     fetcher.mockReturnValue(createSuccess())
     ajs = new Analytics({
       writeKey: 'abc123',

packages/node/src/__tests__/http-integration.test.ts

@@ -5,27 +5,16 @@ import { createSuccess } from './test-helpers/factories'
 import { version } from '../../package.json'
 import { Analytics } from '..'
 import { resolveCtx } from './test-helpers/resolve-ctx'
-
-const myDate = new Date('2016')
-const _Date = Date
+import { createTestAnalytics } from './test-helpers/create-test-analytics'
+import { isValidDate } from './test-helpers/is-valid-date'
 
 describe('Analytics Node', () => {
   let ajs: Analytics
 
   beforeEach(async () => {
-    jest.resetAllMocks()
     fetcher.mockReturnValue(createSuccess())
 
-    ajs = new Analytics({
-      flushInterval: 500,
-      writeKey: 'abc123',
-    })
-
-    // @ts-ignore
-    global.Date = jest.fn(() => myDate)
-    global.Date.UTC = _Date.UTC
-    global.Date.parse = _Date.parse
-    global.Date.now = _Date.now
+    ajs = createTestAnalytics()
   })
 
   test(`Fires an "identify" request with the expected data`, async () => {
@@ -57,9 +46,16 @@ describe('Analytics Node', () => {
         batch: [
           {
             messageId: expect.any(String),
+            context: {
+              library: {
+                version: expect.any(String),
+              },
+            },
+
             _metadata: {
               nodeVersion: expect.any(String),
             },
+            timestamp: expect.any(String),
           },
         ],
       },
@@ -73,12 +69,12 @@ describe('Analytics Node', () => {
             "context": Object {
               "library": Object {
                 "name": "AnalyticsNode",
-                "version": "${version}",
+                "version": Any<String>,
               },
             },
             "integrations": Object {},
             "messageId": Any<String>,
-            "timestamp": "2016-01-01T00:00:00.000Z",
+            "timestamp": Any<String>,
             "traits": Object {
               "foo": "bar",
             },
@@ -89,6 +85,10 @@ describe('Analytics Node', () => {
       }
     `
     )
+
+    const event = body.batch[0]
+    expect(event.context.library.version).toBe(version)
+    expect(isValidDate(event.timestamp)).toBeTruthy()
   })
 
   test('Track: Fires http requests to the correct endoint', async () => {

packages/node/src/__tests__/integration.test.ts

@@ -1,37 +1,19 @@
 const fetcher = jest.fn()
 jest.mock('../lib/fetch', () => fetcher)
 
-import { Analytics } from '../index'
 import { CorePlugin as Plugin } from '@segment/analytics-core'
 import { resolveCtx } from './test-helpers/resolve-ctx'
 import { testPlugin } from './test-helpers/test-plugin'
 import { createSuccess, createError } from './test-helpers/factories'
-import { AnalyticsSettings } from '../app/settings'
+import { createTestAnalytics } from './test-helpers/create-test-analytics'
 
 const writeKey = 'foo'
 jest.setTimeout(10000)
 
-const createTestAnalytics = (settings: Partial<AnalyticsSettings> = {}) => {
-  return new Analytics({ writeKey, flushInterval: 100, ...settings })
-}
-
 beforeEach(() => {
   fetcher.mockReturnValue(createSuccess())
 })
 
-describe('Plugin Init', () => {
-  it('loads analytics-node-next plugin', async () => {
-    const analytics = createTestAnalytics()
-    await analytics.ready
-
-    const ajsNodeXt = analytics.queue.plugins.find(
-      (xt) => xt.name === 'Segment.io'
-    )
-    expect(ajsNodeXt).toBeDefined()
-    expect(ajsNodeXt?.isLoaded()).toBeTruthy()
-  })
-})
-
 describe('Settings / Configuration Init', () => {
   it('throws if no writeKey', () => {
     expect(() =>

packages/node/src/__tests__/plugins.test.ts

@@ -0,0 +1,24 @@
+const fetcher = jest.fn()
+jest.mock('../lib/fetch', () => ({ fetch: fetcher }))
+
+import { createSuccess } from './test-helpers/factories'
+import { createTestAnalytics } from './test-helpers/create-test-analytics'
+
+describe('Plugins', () => {
+  beforeEach(() => {
+    fetcher.mockReturnValue(createSuccess())
+  })
+
+  describe('Initialize', () => {
+    it('loads analytics-node-next plugin', async () => {
+      const analytics = createTestAnalytics()
+      await analytics.ready
+
+      const ajsNodeXt = analytics.queue.plugins.find(
+        (xt) => xt.name === 'Segment.io'
+      )
+      expect(ajsNodeXt).toBeDefined()
+      expect(ajsNodeXt?.isLoaded()).toBeTruthy()
+    })
+  })
+})

packages/node/src/__tests__/test-helpers/create-test-analytics.ts

@@ -0,0 +1,8 @@
+import { Analytics } from '../../app/analytics-node'
+import { AnalyticsSettings } from '../../app/settings'
+
+export const createTestAnalytics = (
+  settings: Partial<AnalyticsSettings> = {}
+) => {
+  return new Analytics({ writeKey: 'foo', flushInterval: 100, ...settings })
+}

packages/node/src/__tests__/test-helpers/is-valid-date.ts

@@ -0,0 +1,6 @@
+export const isValidDate = (date: string) => {
+  if (!date) {
+    throw new Error('no date found.')
+  }
+  return !isNaN(Date.parse(date))
+}