Skip to content

Commit 637b309

Browse files
committed
add factories
1 parent e8f65b6 commit 637b309

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

packages/signals/signals/src/types/factories.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,17 @@ import {
1717
import { normalizeUrl } from '../lib/normalize-url'
1818
import { getPageData } from '../lib/page-data'
1919

20+
type BaseData<T extends SignalTypes> = Omit<
21+
SignalOfType<Signal, T>['data'],
22+
'page'
23+
>
24+
2025
/**
2126
* Base Signal Factory
2227
*/
2328
const createBaseSignal = <
2429
Type extends SignalTypes,
25-
Data extends Omit<SignalOfType<Signal, Type>['data'], 'page'>
30+
Data extends BaseData<Type>
2631
>(
2732
type: Type,
2833
data: Data
@@ -35,7 +40,7 @@ const createBaseSignal = <
3540
...data,
3641
page: getPageData(),
3742
},
38-
} as SignalOfType<Signal, Type>
43+
}
3944
}
4045

4146
export const createInstrumentationSignal = (

0 commit comments

Comments
 (0)