Skip to content

Commit 637fe10

Browse files
committed
fix bug
1 parent 240bae2 commit 637fe10

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

.changeset/slimy-rabbits-agree.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@segment/analytics-signals': patch
3+
---
4+
5+
Fix circular submit error for react-hook-form

packages/signals/signals/src/core/signal-generators/dom-gen/dom-gen.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -140,12 +140,10 @@ const parsePropWithAttributeFallback = (
140140
return
141141
}
142142
// @ts-ignore
143-
const n = element[propName]
144-
if (typeof n === 'string') {
145-
return n
146-
} else if (n instanceof HTMLElement) {
147-
return element.getAttribute(propName) || undefined
148-
}
143+
const val = element[propName]
144+
return typeof val === 'string'
145+
? val
146+
: element.getAttribute(propName) || undefined
149147
}
150148

151149
export const parseElement = (el: HTMLElement): AnyParsedElement => {

0 commit comments

Comments
 (0)