wip

Author: silesky

packages/signals/signals-runtime/src/shared/shared-types.ts

@@ -1,6 +1,8 @@
+export type ID = string | null | undefined
+
 export interface BaseSignal {
   type: string
-  anonymousId: string
+  anonymousId: ID
   timestamp: string
 }
 

packages/signals/signals/src/core/middleware/user-info/index.ts

@@ -1,15 +1,16 @@
 import { Signal } from '@segment/analytics-signals-runtime'
-import { User } from '../../../types'
+import { UserInfo } from '../../../types'
 import { SignalsMiddleware, SignalsMiddlewareContext } from '../../emitter'
 
 export class UserInfoMiddleware implements SignalsMiddleware {
-  user!: User
+  user!: UserInfo
 
   async load(ctx: SignalsMiddlewareContext) {
     this.user = await ctx.analyticsInstance.user()
   }
 
   process(signal: Signal): Signal {
+    // anonymousId should always exist here unless the user is explicitly setting it to null
     signal.anonymousId = this.user.anonymousId()
     return signal
   }

packages/signals/signals/src/types/__tests__/create-network-signal.test.ts

@@ -16,7 +16,6 @@ describe(createNetworkSignal, () => {
       disallowed: ['disallowed1', 'disallowed2'],
     },
   }
-
   it('should create a network signal for a request', () => {
     const data: NetworkData = {
       action: 'request',

packages/signals/signals/src/types/analytics-api.ts

@@ -50,9 +50,11 @@ export interface DestinationMiddlewareParams {
   integration: string
 }
 
-export interface User {
-  id(): string
-  anonymousId(): string
+export type ID = string | null | undefined
+
+export interface UserInfo {
+  id(): ID
+  anonymousId(): ID
 }
 
 export interface AnyAnalytics {
@@ -72,7 +74,7 @@ export interface AnyAnalytics {
   alias(...args: any[]): void
   screen(...args: any[]): void
   reset(): void
-  user(): User | Promise<User>
+  user(): UserInfo | Promise<UserInfo> // works for
   on(name: 'reset', fn: (...args: any[]) => void): void
 }