wip

Author: silesky

packages/signals/signals-runtime/src/runtime-helpers.ts

@@ -1,4 +1,4 @@
-import { BaseSignal, SignalOfType } from './types/shared'
+import { BaseSignal, SignalOfType, ISignalsRuntime } from './types/shared'
 
 /**
  * SignalsRuntime class to manage signals
@@ -13,7 +13,9 @@ import { BaseSignal, SignalOfType } from './types/shared'
  *  type: 'foo'
  * })
  */
-export class SignalsRuntime<Signal extends BaseSignal = BaseSignal> {
+export class SignalsRuntime<Signal extends BaseSignal = BaseSignal>
+  implements ISignalsRuntime<Signal>
+{
   private signalBuffer: Signal[]
   // mobile only - see brandon for this code
   private signalCounter: number

packages/signals/signals-runtime/src/types/shared.ts

@@ -6,3 +6,11 @@ export type SignalOfType<
   AllSignals extends BaseSignal,
   SignalType extends AllSignals['type']
 > = AllSignals & { type: SignalType }
+
+export interface ISignalsRuntime<Signal extends BaseSignal> {
+  find: <SignalType extends Signal['type']>(
+    fromSignal: Signal,
+    signalType: SignalType,
+    predicate?: (signal: SignalOfType<Signal, SignalType>) => boolean
+  ) => SignalOfType<Signal, SignalType> | undefined
+}

packages/signals/signals-runtime/src/types/web/signals.ts

@@ -1,5 +1,3 @@
-import type { BaseSignal, SignalOfType } from '../shared'
-
 export type JSONPrimitive = string | number | boolean | null
 export type JSONValue = JSONPrimitive | JSONObject | JSONArray
 export type JSONObject = { [member: string]: JSONValue }
@@ -110,11 +108,3 @@ export interface SegmentEvent {
   type: string // e.g 'track'
   [key: string]: any
 }
-
-export interface ISignalsRuntime<Signal extends BaseSignal> {
-  find: <SignalType extends Signal['type']>(
-    fromSignal: Signal,
-    signalType: SignalType,
-    predicate?: (signal: SignalOfType<Signal, SignalType>) => boolean
-  ) => SignalOfType<Signal, SignalType> | undefined
-}

packages/signals/signals-runtime/src/web-exports-globals.ts

@@ -1,5 +1,6 @@
 // all import directives will be removed in the final build
-import { ISignalsRuntime, Signal } from './web-exports'
+import { ISignalsRuntime } from './types/shared'
+import { Signal } from './web-exports'
 
 // This will be appended to the generated code - dts-bundle-generator will not write declare const for whatever reason.
 declare const signals: ISignalsRuntime<Signal>