wip

Author: silesky

packages/browser/src/core/arguments-resolver/__tests__/index.test.ts

@@ -415,6 +415,16 @@ describe(resolvePageArguments, () => {
     expect(options).toEqual(baseOptions)
     expect(cb).toEqual(fn)
   })
+
+  test('should accept (callback)', () => {
+    const fn = jest.fn()
+    const [category, name, properties, options, cb] = resolvePageArguments(fn)
+    expect(category).toEqual(null)
+    expect(name).toEqual(null)
+    expect(properties).toEqual({})
+    expect(options).toEqual({})
+    expect(cb).toEqual(fn)
+  })
 })
 
 describe(resolveUserArguments, () => {

packages/browser/src/core/arguments-resolver/index.ts

@@ -96,11 +96,16 @@ export function resolvePageArguments(
   const resolvedCallback = args.find(isFunction) as Callback | undefined
 
   // handle:
+  // - analytics.page('name')
+  // - analytics.page('category', 'name')
   // - analytics.page(properties)
   // - analytics.page(properties, options)
   // - analytics.page('name', properties)
   // - analytics.page('name', properties, options)
   // - analytics.page('category', 'name', properties, options)
+  // - analytics.page('category', 'name', properties, options, callback)
+  // - analytics.page('category', 'name', callback)
+  // - analytics.page(callback), etc
   args.forEach((obj, argIdx) => {
     if (isPlainObject(obj)) {
       if (argIdx === 0) {