Skip to content

Commit 8d49109

Browse files
authored
switch back to node-fetch because of test incompatibility and node 14 issues (#685)
1 parent f15435b commit 8d49109

File tree

5 files changed

+13
-38
lines changed

5 files changed

+13
-38
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
"@npmcli/promise-spawn": "^3.0.0",
3939
"@types/jest": "^28.1.1",
4040
"@types/lodash": "^4",
41+
"@types/node-fetch": "^2.6.2",
4142
"@typescript-eslint/eslint-plugin": "^5.21.0",
4243
"@typescript-eslint/parser": "^5.21.0",
4344
"concurrently": "^7.2.1",

packages/browser/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@
7171
"@types/jsdom": "^16.2.14",
7272
"@types/mime": "^2.0.3",
7373
"@types/node": "^12.12.14",
74-
"@types/node-fetch": "^2.5.7",
7574
"@types/serve-handler": "^6.1.0",
7675
"@types/spark-md5": "^3.0.2",
7776
"aws-sdk": "^2.814.0",

packages/node/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@
3535
"dependencies": {
3636
"@lukeed/uuid": "^2.0.0",
3737
"@segment/analytics-core": "1.1.2",
38-
"tslib": "^2.4.0",
39-
"undici": "^5.12.0"
38+
"node-fetch": "^2.6.7",
39+
"tslib": "^2.4.0"
4040
},
4141
"devDependencies": {
4242
"@internal/config": "0.0.0",

packages/node/src/lib/fetch.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
import { fetch as _fetch } from 'undici'
1+
import { default as _fetch } from 'node-fetch'
22

33
export const fetch = globalThis.fetch || _fetch

yarn.lock

Lines changed: 9 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1852,7 +1852,6 @@ __metadata:
18521852
"@types/jsdom": ^16.2.14
18531853
"@types/mime": ^2.0.3
18541854
"@types/node": ^12.12.14
1855-
"@types/node-fetch": ^2.5.7
18561855
"@types/serve-handler": ^6.1.0
18571856
"@types/spark-md5": ^3.0.2
18581857
aws-sdk: ^2.814.0
@@ -1897,8 +1896,8 @@ __metadata:
18971896
"@lukeed/uuid": ^2.0.0
18981897
"@segment/analytics-core": 1.1.2
18991898
"@types/node": ^14
1899+
node-fetch: ^2.6.7
19001900
tslib: ^2.4.0
1901-
undici: ^5.12.0
19021901
languageName: unknown
19031902
linkType: soft
19041903

@@ -3543,13 +3542,13 @@ __metadata:
35433542
languageName: node
35443543
linkType: hard
35453544

3546-
"@types/node-fetch@npm:^2.5.7":
3547-
version: 2.5.7
3548-
resolution: "@types/node-fetch@npm:2.5.7"
3545+
"@types/node-fetch@npm:^2.6.2":
3546+
version: 2.6.2
3547+
resolution: "@types/node-fetch@npm:2.6.2"
35493548
dependencies:
35503549
"@types/node": "*"
35513550
form-data: ^3.0.0
3552-
checksum: 41079d4898d66dbaea9911015c3f35694c20806dc8300bab77f3d0e46b89e967e89e7301a884c12c594bd770a24ae27fd393fc36d14747cf57bb1e24f9cfbcb7
3551+
checksum: 6f73b1470000d303d25a6fb92875ea837a216656cb7474f66cdd67bb014aa81a5a11e7ac9c21fe19bee9ecb2ef87c1962bceeaec31386119d1ac86e4c30ad7a6
35533552
languageName: node
35543553
linkType: hard
35553554

@@ -4434,6 +4433,7 @@ __metadata:
44344433
"@npmcli/promise-spawn": ^3.0.0
44354434
"@types/jest": ^28.1.1
44364435
"@types/lodash": ^4
4436+
"@types/node-fetch": ^2.6.2
44374437
"@typescript-eslint/eslint-plugin": ^5.21.0
44384438
"@typescript-eslint/parser": ^5.21.0
44394439
concurrently: ^7.2.1
@@ -5118,15 +5118,6 @@ __metadata:
51185118
languageName: node
51195119
linkType: hard
51205120

5121-
"busboy@npm:^1.6.0":
5122-
version: 1.6.0
5123-
resolution: "busboy@npm:1.6.0"
5124-
dependencies:
5125-
streamsearch: ^1.1.0
5126-
checksum: 32801e2c0164e12106bf236291a00795c3c4e4b709ae02132883fe8478ba2ae23743b11c5735a0aae8afe65ac4b6ca4568b91f0d9fed1fdbc32ede824a73746e
5127-
languageName: node
5128-
linkType: hard
5129-
51305121
"bytes-iec@npm:^3.1.1":
51315122
version: 3.1.1
51325123
resolution: "bytes-iec@npm:3.1.1"
@@ -7488,13 +7479,13 @@ __metadata:
74887479
linkType: hard
74897480

74907481
"form-data@npm:^3.0.0":
7491-
version: 3.0.0
7492-
resolution: "form-data@npm:3.0.0"
7482+
version: 3.0.1
7483+
resolution: "form-data@npm:3.0.1"
74937484
dependencies:
74947485
asynckit: ^0.4.0
74957486
combined-stream: ^1.0.8
74967487
mime-types: ^2.1.12
7497-
checksum: 60ec3fe7e23154949ab6fef31baedf5afbfb8d6441ea8d19b211b43a5d0448be2918c9bba6218cade56a7cbd43f670d6e75f41f626f8d397d56bf8c60f4a829d
7488+
checksum: b019e8d35c8afc14a2bd8a7a92fa4f525a4726b6d5a9740e8d2623c30e308fbb58dc8469f90415a856698933c8479b01646a9dff33c87cc4e76d72aedbbf860d
74987489
languageName: node
74997490
linkType: hard
75007491

@@ -12700,13 +12691,6 @@ __metadata:
1270012691
languageName: node
1270112692
linkType: hard
1270212693

12703-
"streamsearch@npm:^1.1.0":
12704-
version: 1.1.0
12705-
resolution: "streamsearch@npm:1.1.0"
12706-
checksum: 1cce16cea8405d7a233d32ca5e00a00169cc0e19fbc02aa839959985f267335d435c07f96e5e0edd0eadc6d39c98d5435fb5bbbdefc62c41834eadc5622ad942
12707-
languageName: node
12708-
linkType: hard
12709-
1271012694
"string-argv@npm:^0.3.1":
1271112695
version: 0.3.1
1271212696
resolution: "string-argv@npm:0.3.1"
@@ -13683,15 +13667,6 @@ __metadata:
1368313667
languageName: node
1368413668
linkType: hard
1368513669

13686-
"undici@npm:^5.12.0":
13687-
version: 5.12.0
13688-
resolution: "undici@npm:5.12.0"
13689-
dependencies:
13690-
busboy: ^1.6.0
13691-
checksum: fbc227704943c05aa3dc1630695e10309c17d0a535678594d136db107c50593248e9ace70e1ab77496a6c837bf14aa2ab3c501a7a6c45fb6277dbf0846e15ffe
13692-
languageName: node
13693-
linkType: hard
13694-
1369513670
"unfetch@npm:^3.1.1":
1369613671
version: 3.1.2
1369713672
resolution: "unfetch@npm:3.1.2"

0 commit comments

Comments
 (0)