wip

Author: silesky

packages/signals/signals/src/core/middleware/user-info/index.ts

@@ -0,0 +1,17 @@
+import { Signal } from '@segment/analytics-signals-runtime'
+import { User } from '../../../types'
+import { SignalsMiddleware, SignalsMiddlewareContext } from '../../emitter'
+
+export class UserInfoMiddleware implements SignalsMiddleware {
+  ctx!: SignalsMiddlewareContext
+  user!: User
+
+  async load(ctx: SignalsMiddlewareContext) {
+    this.user = await ctx.analyticsInstance.user()
+  }
+
+  process(signal: Signal): Signal {
+    signal.anonymousId = this.user.anonymousId()
+    return signal
+  }
+}

packages/signals/signals/src/core/signal-generators/dom-gen/__tests__/change-gen.test.ts

@@ -1,8 +1,7 @@
-import { createInteractionSignal } from '../../../../types/factories'
 import { SignalEmitter } from '../../../emitter'
 import { OnChangeGenerator } from '../change-gen'
 
-describe('OnChangeGenerator', () => {
+describe(OnChangeGenerator, () => {
   let onChangeGenerator: OnChangeGenerator
   let emitter: SignalEmitter
   let unregister: () => void
@@ -28,14 +27,49 @@ describe('OnChangeGenerator', () => {
     unregister = onChangeGenerator.register(emitter)
     document.dispatchEvent(event)
 
-    expect(emitSpy).toHaveBeenCalledWith(
-      createInteractionSignal({
-        eventType: 'change',
-        listener: 'onchange',
-        target: expect.any(Object),
-        change: { value: 'new value' },
-      })
-    )
+    expect(emitSpy.mock.calls.length).toBe(1)
+    expect(emitSpy.mock.calls[0][0]).toMatchInlineSnapshot(`
+      {
+        "anonymousId": "",
+        "data": {
+          "change": {
+            "value": "new value",
+          },
+          "eventType": "change",
+          "listener": "onchange",
+          "page": {
+            "hash": "",
+            "hostname": "localhost",
+            "path": "/",
+            "referrer": "",
+            "search": "",
+            "title": "",
+            "url": "http://localhost/",
+          },
+          "target": {
+            "attributes": {
+              "type": "text",
+            },
+            "checked": false,
+            "classList": [],
+            "describedBy": undefined,
+            "id": "",
+            "innerText": undefined,
+            "label": undefined,
+            "labels": [],
+            "name": "",
+            "nodeName": "INPUT",
+            "tagName": "INPUT",
+            "textContent": "",
+            "title": "",
+            "type": "text",
+            "value": "new value",
+          },
+        },
+        "timestamp": <ISO Timestamp>,
+        "type": "interaction",
+      }
+    `)
   })
 
   it('should not emit a signal for ignored elements', () => {
@@ -85,15 +119,58 @@ describe('OnChangeGenerator', () => {
     unregister = onChangeGenerator.register(emitter)
     document.dispatchEvent(event)
 
-    expect(emitSpy).toHaveBeenCalledWith(
-      createInteractionSignal({
-        eventType: 'change',
-        listener: 'onchange',
-        target: expect.any(Object),
-        change: {
-          selectedOptions: [{ value: 'value1', label: 'label1' }],
+    expect(emitSpy.mock.lastCall).toMatchInlineSnapshot(`
+      [
+        {
+          "anonymousId": "",
+          "data": {
+            "change": {
+              "selectedOptions": [
+                {
+                  "label": "label1",
+                  "value": "value1",
+                },
+              ],
+            },
+            "eventType": "change",
+            "listener": "onchange",
+            "page": {
+              "hash": "",
+              "hostname": "localhost",
+              "path": "/",
+              "referrer": "",
+              "search": "",
+              "title": "",
+              "url": "http://localhost/",
+            },
+            "target": {
+              "attributes": {},
+              "classList": [],
+              "describedBy": undefined,
+              "id": "",
+              "innerText": undefined,
+              "label": undefined,
+              "labels": [],
+              "name": "",
+              "nodeName": "SELECT",
+              "selectedIndex": 0,
+              "selectedOptions": [
+                {
+                  "label": "label1",
+                  "value": "value1",
+                },
+              ],
+              "tagName": "SELECT",
+              "textContent": "",
+              "title": "",
+              "type": "select-one",
+              "value": "value1",
+            },
+          },
+          "timestamp": <ISO Timestamp>,
+          "type": "interaction",
         },
-      })
-    )
+      ]
+    `)
   })
 })

packages/signals/signals/src/types/analytics-api.ts

@@ -50,6 +50,11 @@ export interface DestinationMiddlewareParams {
   integration: string
 }
 
+export interface User {
+  id(): string
+  anonymousId(): string
+}
+
 export interface AnyAnalytics {
   settings: {
     cdnSettings: CDNSettings
@@ -67,6 +72,7 @@ export interface AnyAnalytics {
   alias(...args: any[]): void
   screen(...args: any[]): void
   reset(): void
+  user(): User | Promise<User>
   on(name: 'reset', fn: (...args: any[]) => void): void
 }