wip

Author: silesky

packages/signals/signals/package.json

@@ -33,7 +33,7 @@
     "build:bundle": "NODE_ENV=production yarn run webpack",
     "workerbox": "node scripts/build-workerbox.js",
     "assert-generated": "sh scripts/assert-workerbox-built.sh",
-    "watch": "yarn concurrently 'yarn build:bundle --watch' 'yarn build:esm --watch'",
+    "watch": "rm -rf dist && yarn concurrently 'yarn build:bundle --watch' 'yarn build:esm --watch'",
     "version": "sh scripts/version.sh",
     "watch:test": "yarn test --watch",
     "tsc": "yarn run -T tsc",

packages/signals/signals/src/core/signal-generators/dom-gen/dom-gen.ts

@@ -263,14 +263,16 @@ export class OnChangeGenerator implements SignalGenerator {
       if (this.shouldIgnore(target)) {
         return
       }
-
+      const el = parseElement(ev.element)
       emitter.emit(
         createInteractionSignal({
           eventType: 'change',
-          target: parseElement(ev.element),
-          metadata: {
+          target: {
+            ...el,
+            changedValue: ev.newValue,
             changedAttribute: ev.attributeName,
-            changeAttributeVal: ev.newValue,
+          },
+          metadata: {
             listener: 'mutation-observer',
           },
         })
@@ -285,10 +287,15 @@ export class OnChangeGenerator implements SignalGenerator {
         return
       }
 
+      const el = parseElement(target)
       emitter.emit(
         createInteractionSignal({
           eventType: 'change',
-          target: parseElement(target),
+          target: {
+            ...el,
+            changedValue: el.value,
+            changedAttribute: 'value',
+          },
           metadata: {
             listener: 'on-change',
           },

packages/signals/signals/src/core/signal-generators/dom-gen/mutation-observer.ts

@@ -40,7 +40,6 @@ const defaultElementAttributesMap = {
 type AttributeChangedEvent = {
   type: 'interaction' | 'alert'
   element: HTMLElement
-  describedElement: HTMLElement | null
   attributeName: string
   newValue: string | null
 }
@@ -99,15 +98,10 @@ export class ElementChangeObservable {
           if (newValue === null) {
             return console.warn('New value is null?', attributeName)
           }
-          const describedElement = element.getAttribute('aria-describedby')
           const event: AttributeChangedEvent = {
             type: 'interaction',
             element: element as HTMLElement,
             attributeName,
-            // this is innacurate
-            describedElement: describedElement
-              ? document.getElementById(describedElement)
-              : null,
             newValue,
           }
           emitter.emit('attributeChanged', event)