Skip to content

Commit b657a24

Browse files
committed
wip
1 parent 2da7141 commit b657a24

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

packages/consent/consent-tools/src/types/wrapper.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,8 @@ export interface CDNSettings {
144144
* { "Fullstory": {...}, "Braze Web Mode (Actions)": {...}}
145145
*/
146146
export interface CDNSettingsIntegrations {
147-
'Segment.io': any
148-
[integrationName: string]: Record<string, any>
147+
'Segment.io': Record<string, unknown>
148+
[integrationName: string]: Record<string, unknown>
149149
}
150150

151151
export interface CDNSettingsRemotePlugin {

packages/signals/signals/src/core/analytics-service/index.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import { CDNSettings } from '@segment/analytics-next'
2-
import { AnyAnalytics } from '../../types'
1+
import { AnyAnalytics, CDNSettings } from '../../types'
32
import { SignalGenerator } from '../signal-generators/types'
43
import { createInstrumentationSignal } from '../../types/factories'
54

packages/signals/signals/src/types/analytics-api.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ export type AutoInstrumentationCDNSettings = {
1313
}
1414

1515
export interface CDNSettings {
16-
integrations: CDNSettingsIntegrations
17-
edgeFunction?: EdgeFnCDNSettings | { [key: string]: never }
16+
edgeFunction?: EdgeFnCDNSettings | {}
1817
autoInstrumentationSettings?: AutoInstrumentationCDNSettings
1918
[key: string]: unknown
2019
}
@@ -77,8 +76,8 @@ export interface AnyAnalytics {
7776
* { "Fullstory": {...}, "Braze Web Mode (Actions)": {...}}
7877
*/
7978
export interface CDNSettingsIntegrations {
80-
'Segment.io': any
81-
[integrationName: string]: { [key: string]: any }
79+
'Segment.io': any // this is unsafe, but it's also backward compatible and will have
80+
[integrationName: string]: Record<string, unknown>
8281
}
8382

8483
export type PluginType = 'before' | 'after' | 'destination'

0 commit comments

Comments
 (0)